Repository navigation
ppd-cache.c: Guard against empty options in ppdCacheAssignPresets() - #110
Merged
tillkamppeter merged 1 commit intoNov 14, 2026
Merged
tillkamppeter merged 1 commit into
tillkamppeter merged 1 commit into
Conversation
In ppdCacheAssignPresets(), skip options with option->num_choices <= 0 or a NULL choices array before inspecting option->choices[0].choice in the Foomatic composite-option check. Previously, a Foomatic PPD containing an empty *OpenUI/*CloseUI block triggered a near-NULL read in strncmp(). Add regression test T53 in ppd/test_ppd_cache.c verifying ppdCacheCreateWithPPD() succeeds on a Foomatic PPD with an empty OpenUI option. Fixes OpenPrinting#81 Signed-off-by: Ronit Mehta <ronitdmehta@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
In ppdCacheAssignPresets() (ppd/ppd-cache.c), the Foomatic composite-option check accesses option->choices[0].choice without verifying that option->num_choices > 0 and option->choices != NULL. A Foomatic PPD containing an empty *OpenUI / *CloseUI block triggers a near-NULL read (SEGV) in strncmp().
Changes
Fixes #81