Repository navigation
ppd.c: Free existing strings on duplicate JCL and header keywords - #109
Merged
tillkamppeter merged 1 commit intoNov 14, 2026
Conversation
In ppdOpenWithLocalization(), free any previously allocated string before overwriting ppd->lang_encoding, ppd->nickname, ppd->jcl_begin, ppd->jcl_end, ppd->jcl_ps, and ppd->jcl_pdf when duplicate keywords appear in a PPD file. Add regression test T47 in ppd/test_ppd_emit.c verifying that duplicate JCLBegin, JCLEnd, JCLToPSInterpreter, NickName, and LanguageEncoding lines retain the final decoded values without leaking memory under LeakSanitizer. Fixes OpenPrinting/fuzzing#46 Signed-off-by: Ronit Mehta <ronitdmehta@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When
ppdOpenWithLocalization()(ppd/ppd.c) parses a PPD containing duplicate*JCLBegin,*JCLEnd,*JCLToPSInterpreter,*JCLToPDFInterpreter,*NickName, or*LanguageEncodingkeywords, it callsstrdup()and overwrites the struct member pointer without freeing the prior allocation, leaking the previous string.Changes
free()onppd->lang_encoding,ppd->nickname,ppd->jcl_begin,ppd->jcl_end,ppd->jcl_ps, andppd->jcl_pdf(#if HAVE_CUPS_3_X) before reassigning them inppdOpenWithLocalization().T47inppd/test_ppd_emit.cverifying that a PPD with duplicate*JCLBegin,*JCLEnd,*JCLToPSInterpreter,*NickName, and*LanguageEncodingkeywords retains the latest decoded values and closes cleanly with zero leaks under AddressSanitizer / LeakSanitizer.Fixes OpenPrinting/fuzzing#46