Repository navigation
Conversation
rusty1968
marked this pull request as ready for review
November 6, 2026 03:11
JesseMelon
reviewed
Nov 9, 2026
21 tasks
Contributor
|
The shape of this PR changed after the initial review, via 3 follow-up commits
Verified with Leaving this open pending approval — flagging for re-review given the shape change, rather than |
JesseMelon
force-pushed
the
ast10x0-target
branch
4 times, most recently
from
November 19, 2026 16:27
b5836e9 to
1593195
Compare
Gate services/drivers crates on KERNEL_TARGET_COMPATIBLE_WITH (os:none) rather than ast10x0's constraint, removing the dependency of shared code on //target/ast10x0 so the SoC can become a nested module. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
target/ast10x0 is now its own module (openprot_ast10x0) that depends on the enclosing checkout via local_path_override, following pigweed's adventure example, so it can later move out of tree with a git_override. - Add MODULE.bazel/.bazelrc/.bazelversion; run bazel from target/ast10x0. - Repeat openprot's root-only overrides and share its crate universe via override_repo. - Move the AST1060 PAC extension out of the root MODULE.bazel. - Re-point labels to @openprot// and module-relative. - Ignore target/ast10x0 in the root; run its presubmit from the subdir. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Sort deps so @openprot// and other labels follow buildifier order, and add the blank lines buildifier expects in MODULE.bazel, as required by the presubmit format check. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
A nested module such as target/ast10x0 is a Bazel root when built on its own, so it repeats the git_override pins (Pigweed, ureg) and the Rust toolchain cipd_tag from the root MODULE.bazel. Nothing notices when the copies drift, so fail the presubmit if a pin set in more than one MODULE.bazel differs between them. This is a stop-gap: it detects drift but does not remove the duplication. Delete it if the pins move to a single source, such as an in-repo registry. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
… instead of duplicating them
…t detected pins.MODULE.bazel is the single source of truth for the pigweed/ureg commits, the opentitan_devbundle archive hash, the pw_rust cipd_tag, and the shared bazel_dep versions — module_pins.py has nothing left to compare for any of them. Its own docstring already called for this: "delete it if the pins move to a single source."
JesseMelon
force-pushed
the
ast10x0-target
branch
from
November 19, 2026 16:35
1593195 to
e4bf68a
Compare
Collaborator
Author
|
Transferring ownership to @JesseMelon |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on the guidelines of pigweed's adventure game project. A stepping stone for out-of-tree SoC modules.
Update: Since this PR was opened, its shape changed with 3 follow-up commits:
opentitan_devbundlearchive hash, thepw_rustcipd_tag,and 5 shared
bazel_depversions are no longer duplicated betweenMODULE.bazelandtarget/ast10x0/MODULE.bazel— they now live once inpins.MODULE.bazel, which bothinclude().presubmit/module_pins.py(the drift-detector for a subset of those same values) isremoved; with nothing left to drift, a detect-after-the-fact check added no value, and
its own docstring already said to delete it once the pins moved to a single source.
tools/sgpiom/README.mdhad a broken build example (a literal(from target/ast10x0)string left inside a copy-pasteable bash block by the bulk label rewrite) — fixed.
Verified both the root build and the standalone target/ast10x0 module build, at every step of the rebase onto main:
bazelisk mod graph --output=text
bazelisk query //...
run from the repo root, and again from inside target/ast10x0, after each conflict resolution — confirms the module graph resolves and every package loads cleanly on both sides.
Followed up with real compiles (not just query) on rot-beast:
From the repo root — exercises the VeeR PIC code the two Pigweed patches touch
bazelisk build //target/veer/...
→ 110 targets, 2473 actions, build succeeded.
Inside target/ast10x0 — the standalone nested-module build
cd target/ast10x0
bazelisk build //...
→ 366 targets, 2879 actions, build succeeded.