Skip to content

Migrate session fact consumers and repair their worker/error controls - #2140

Merged
trissim merged 2 commits into
mainfrom
perf/session-fact-imports
Nov 18, 2026
Merged

trissim merged 2 commits into
mainfrom
perf/session-fact-imports

Conversation

@trissim

@trissim trissim commented Nov 18, 2026 •

Copy link
Copy Markdown

Core fact consumer migration

Companion to OpenHCSDev/agent-comms#4902. Requires its session_updates and AcpUpdateSink declarations; integrate the pair before deployment. No production Toad code changes.

  • Migrate all selected test/peer encoder imports to their actual shared fact owner, without Core compatibility exports.
  • The compaction Pipe adapter inherits AcpUpdateSink, retaining its original raw JSON-RPC publication and acknowledgement.
  • Warm helper descriptor relocation derives its safe range from the actual target descriptors, replacing the invalid hard-coded 1024 floor under a 1024 soft limit.
  • The shared async reporting_error context owns waiting for and acknowledging exactly one expected notification. Migrate all eleven callers, preserving ordering of synchronous mocks and pytest exception guards. Unexpected/extra errors still fail.
  • Failure controls retain draft recovery and terminal-versus-request distinctions, use the correct nominal ACPFailure value, and open the real model picker after provider failure instead of asserting a deleted convenience property.

Executed checks

35 passed, exit 0, against Core 862bed033 and Toad base 8ad9fab. Covers transcript/recipient identity, thread and process validation workers, cursor results, titles, failed draft recovery, model selection, single-draw behavior and all changed expected-error callers. No physical desktop/window check or total CPU saving claimed.

The additional real compaction producer control: 1 passed, exit 0, after its Pipe migration. Earlier failed runs are retained: descriptor limit, stale error timing/property/type assumptions, and an unsuitable stdin pytest launcher. The rerun uses python -m pytest so multiprocessing has a real main module.

All source edits were declaration-selected NRA plans, simulated and inspected before application. No user window was closed or restarted; no failed user input was replayed.

@trissim
trissim merged commit e5eff11 into main Nov 18, 2026
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant