Repository navigation
Migrate session fact consumers and repair their worker/error controls - #2140
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Core fact consumer migration
Companion to OpenHCSDev/agent-comms#4902. Requires its session_updates and AcpUpdateSink declarations; integrate the pair before deployment. No production Toad code changes.
Executed checks
35 passed, exit 0, against Core 862bed033 and Toad base 8ad9fab. Covers transcript/recipient identity, thread and process validation workers, cursor results, titles, failed draft recovery, model selection, single-draw behavior and all changed expected-error callers. No physical desktop/window check or total CPU saving claimed.
The additional real compaction producer control: 1 passed, exit 0, after its Pipe migration. Earlier failed runs are retained: descriptor limit, stale error timing/property/type assumptions, and an unsuitable stdin pytest launcher. The rerun uses python -m pytest so multiprocessing has a real main module.
All source edits were declaration-selected NRA plans, simulated and inspected before application. No user window was closed or restarted; no failed user input was replayed.