Repository navigation
qt: generic helpers use QWidget.window; shipped_run reads qt_drive's OUTDIR - #2136
Merged
Merged
Conversation
QtConversation names its scroll surface `window` (the shared contract Textual answers), so parent.window() on a conversation returned the history list: opening session details raised 'QtHistoryWindow' object is not callable (the APK's shipped-app check). The presented window's host and the floating menu take any widget, so they call QWidget.window(widget). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01RnH6dT7wdh7i4tjJZQdFu3
…rive keeps them (OUTDIR) Since qt_drive always keeps settings and state under OUTDIR, shipped_run's toad.json in kept/config was never read (the app started on 'wal', failing the theme check) and its error files under kept/state were never found. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01RnH6dT7wdh7i4tjJZQdFu3
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01RnH6dT7wdh7i4tjJZQdFu3
trissim
added a commit
that referenced
this pull request
Nov 18, 2026
…te (#2138) #2136 moved this lookup to qt_drive's OUTDIR with the other two; but the crash check runs the app directly (shipped_fault), which writes its trace under kept/state. The APK build then failed every time with 'a faulted run exited -11 with 0 trace file(s)'. Claude-Session: https://claude.ai/code/session_01RnH6dT7wdh7i4tjJZQdFu3 Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
QWidget.window(widget): QtConversation names its scroll surfacewindow, soparent.window()on a conversation returned the history list and opening session details raised (APK shipped-app check).Gate: the APK build's shipped-app check passes on this head.
🤖 Generated with Claude Code
https://claude.ai/code/session_01RnH6dT7wdh7i4tjJZQdFu3