Skip to content

qt: generic helpers use QWidget.window; shipped_run reads qt_drive's OUTDIR - #2136

Merged
trissim merged 3 commits into
mainfrom
qwidget-window-explicit
Nov 18, 2026
Merged

trissim merged 3 commits into
mainfrom
qwidget-window-explicit

Conversation

@trissim

@trissim trissim commented Nov 18, 2026

Copy link
Copy Markdown
  • presented windows and the floating menu reach the top-level window through QWidget.window(widget): QtConversation names its scroll surface window, so parent.window() on a conversation returned the history list and opening session details raised (APK shipped-app check).
  • shipped_run saves its unoffered theme and reads error files and fault traces under qt_drive's OUTDIR, where the drive now always keeps settings and state.

Gate: the APK build's shipped-app check passes on this head.

🤖 Generated with Claude Code

https://claude.ai/code/session_01RnH6dT7wdh7i4tjJZQdFu3

trissim and others added 3 commits November 18, 2026 14:52
QtConversation names its scroll surface `window` (the shared contract Textual answers),
so parent.window() on a conversation returned the history list: opening session details
raised 'QtHistoryWindow' object is not callable (the APK's shipped-app check). The
presented window's host and the floating menu take any widget, so they call
QWidget.window(widget).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01RnH6dT7wdh7i4tjJZQdFu3
…rive keeps them (OUTDIR)

Since qt_drive always keeps settings and state under OUTDIR, shipped_run's toad.json in
kept/config was never read (the app started on 'wal', failing the theme check) and its
error files under kept/state were never found.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01RnH6dT7wdh7i4tjJZQdFu3
@trissim
trissim merged commit 5d5e23d into main Nov 18, 2026
trissim added a commit that referenced this pull request Nov 18, 2026
…te (#2138)

#2136 moved this lookup to qt_drive's OUTDIR with the other two; but the crash check runs
the app directly (shipped_fault), which writes its trace under kept/state. The APK build
then failed every time with 'a faulted run exited -11 with 0 trace file(s)'.


Claude-Session: https://claude.ai/code/session_01RnH6dT7wdh7i4tjJZQdFu3

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant