Repository navigation
phone: a tall arrival pins its header, a burst's last messages are read, menu lines keep their descenders - #2127
Merged
Merged
Conversation
…eader scrolling The scroll handler returned for the window's own scrolls (`layout_scroll`: the arrival glide, landing on the end, keeping the reader) before it repinned, so a message taller than the window that the reader followed into kept the previous message's header pinned until they scrolled (Tristan, Android). Every offset now repins, as `repin_header` says it is called and as Textual does. `tall_arrival` drives it on the live bus: #scratch following its end, scratch-live-pipeline posts 120 lines. Before: pinned "user -> #scratch 10:08:20" (the previous message). After: pinned "#scratch <- scratch-live-pipeline 10:14:10", the arrival's own header. `arrival` takes BURST (posts at once, default 3) and reports each post's wait to its row. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01RnH6dT7wdh7i4tjJZQdFu3
…ir descenders
QtMenuRow set its button's minimum height to `lines x lineSpacing + margins`, and an explicit
minimum overrides the layout's own: each line (an ElidedLine with 5 px contents margins) got
22 px, 12 of them for a 17 px font, which cut every descender on the phone ("proiect",
"aqent's"). The row now takes its layout's own minimum (`totalMinimumSize`), never less
than the touch target. `qt_drive menu_text` (touch, 412 wide): before 22 lines drawn at
12/17 px; after 22 lines at 17/17, none clipped.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01RnH6dT7wdh7i4tjJZQdFu3
…hen it ends
`WorkingTranscript.schedule_work` answered DEFERRED_WORK ("the caller decides whether to
retry") and no caller retried: a revision's refresh that arrived while a page read ran was
dropped. In a burst the last revisions always land mid-read, so its last messages stayed
unread until something else changed. The working state now keeps such work (once per kind:
a refresh reads everything new) and `finish_source_work` schedules it when the read ends;
what arrives meanwhile is owed to that operation in turn. Shared pager: both frontends.
`qt_drive arrival` with BURST=20 at phone speed (CPUQuota=45%, py-spy attached): before,
14 of 20 shown, the last 6 never; after, 20 of 20 in two runs, median wait 0.7-1.0 s.
The drive now reports each post's wait, when Core's revisions reached the app, and
`menu_text` checks menu lines under touch for clipping.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01RnH6dT7wdh7i4tjJZQdFu3
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Three things Tristan reported on Android, each reproduced in a live-bus drive, fixed, and shown fixed by the same drive.
1. A tall arrival's header stays the previous message's
The Qt scroll handler returned for the window's own scrolls (
layout_scroll: the arrival glide, landing on the end, keeping the reader) before it repinned. So a message taller than the window, which the reader followed into, left the previous message's header pinned until they scrolled. Every offset now repins, asrepin_header's docstring says and as Textual does.tall_arrival(#scratch following the end; scratch-live-pipeline posts 120 lines):user -> #scratch 10:08:20, the previous message.#scratch <- scratch-live-pipeline 10:14:10, the arrival's own header.2. A burst's last messages stay unread
WorkingTranscript.schedule_workansweredDEFERRED_WORK("the caller decides whether to retry"), and no caller, in either frontend, retried. A revision's refresh that arrived while a page read ran was therefore dropped. In a burst the last revisions always land mid-read, so its last messages stayed unread until something else changed.The working state now keeps such work, once per kind, since one refresh reads everything new.
finish_source_workschedules it when the read ends, and whatever arrives meanwhile is owed to that next operation in turn. This is in the shared pager, so both frontends get it.arrivalwithBURST=20at phone speed (CPUQuota=45%, py-spy attached):The drive also prints when Core's revisions reached the app. They arrive every 0.3–0.5 s; the view steps about once a second, because a page read takes that long at phone speed.
3. Menu descriptions lose their descenders
QtMenuRowset an explicit minimum height oflines x lineSpacing + margins, which overrides the layout's own minimum. EachElidedLine(5 px contents margins) got 22 px, 12 of them for a 17 px font. The row now takes its layout'stotalMinimumSize, never less than the touch target.menu_text(touch, 412 wide):Gates (on d873bee)
check.shwith PYTHONFAULTHANDLER=1: exit 0, no fatal or traceback lines. The realtoad.jsonwas untouched.agent_commson the path, because the editable agent-comms checkout is on another branch.🤖 Generated with Claude Code
https://claude.ai/code/session_01RnH6dT7wdh7i4tjJZQdFu3