Repository navigation
Conversation
…ver the text A message header's rule was a count of ─ characters beside the title, so its ends moved with the title's length and never met the row's edges. Qt now draws each side as a real line in its own cell (the theme's RuleColour), so every rule meets both edges whatever the title; the TUI keeps its cell rule. The Scrollbar setting declares, per member, the width it takes beside the text (`size`) and the width it draws over the text while the conversation moves (`overlay`). The new Transient member takes no width and shows a bar over the text while scrolling, faded out a second after; Hidden shows none. Qt floats the overlay over the viewport (OverlayScrollBar, handle in SurfaceHoverColour, fading on the app clock through SCROLLBAR_FADE); a terminal cannot draw over its text, so Textual shows `size` only and Transient is no bar there. The default is the platform's: Transient on Android, Normal elsewhere. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01RnH6dT7wdh7i4tjJZQdFu3
Author
|
Merged as part of #2130: this branch was rebased onto main and gated together with the other UI branches, since they edit the same lines. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two of Tristan's phone requests:
Depends on ui-theme#33 (
RuleColour), then a runtime rebuild. The rule colour isui_theme.scheme.RuleColour, from the contrast fork's ui-theme branch. With today's installed runtime,toad.qt.linesfails to import. Rollout: merge ui-theme#33, then pyqt-reactive, then rebuild the runtime, then merge this.Header rules
The shared
Divideralready describes a header as structure: title spans, a role and a timestamp. Only Qt's renderer turned the rule into a whole number of─characters on each side of the title. So each rule's ends moved with the title's length and never met the row's edges.Qt now draws each side as a real line in its own table cell, coloured
RuleColour. The title's cell takes its content's width and the two sides share the rest, so every rule meets both edges whatever the title. Wrapped titles still give one row per line, as Textual does, and row height is unchanged. The sticky header draws through the same renderer (header_document), so it gets the same rule. Textual's divider code is untouched and keeps drawing its rule in cells.The same titles rendered at 380 px, measuring where the rule's pixels start and end:
Aluser#scratch <── userscratch-live-pipeline ──> #scratcha much longer sender nameIn the live drive (
header_ruleonscratch-live-pipeline, phone profile), every header's rule spans 0–186 of its 187 px row, for titles of 17, 30 and 34 characters.Scrollbar
The
Scrollbarfamily declares, per member:size: the cells it takes beside the text;overlay(new): the cells it draws over the text while the conversation moves.Platform.select: Transient on Android, Normal everywhere else (Scrollbar.for_host()).FamilyChoices(Scrollbar), and applies live throughconversation_layout.OverlayScrollBarmirrors the area's own bar, which stays the model of the position, so dragging it scrolls and any scroll shows it.SurfaceHoverColour.SCROLLBAR_FADE) throughWidgetAnimation, so a destroyed view stops it.QT_ONLY; the shared fact isScrollbar.overlay.The
header_ruledrive, phone profile,scratch-live-pipeline:I read the screenshots for each step.
Gates, on this head (2b66d73), with ui-theme#33's
ui_themeheader_rule,history,arrival,chrome): each exit 0, with 0 error files and 0 tracebacks. These ran with ui-theme#33 onPYTHONPATH.tools/android/check.shwithPYTHONFAULTHANDLER=1: exit 0, including the shipped app on a scratch bus. It ran against a copy of the installed runtime whoseui_themeis ui-theme#33's.TimeoutError: welcome rows. The host's out-of-memory kill at 04:53 took down the user manager that serves the live bus, which was still down when this was written.Overlap
The history fork (fork-qt-history-snappy) is in
qt/history.py. This PR doesn't touch that file: the rule is inqt/lines.py, and the scrollbar is inqt/view_settings.pyplus the newqt/overlay_scrollbar.py.🤖 Generated with Claude Code
https://claude.ai/code/session_01RnH6dT7wdh7i4tjJZQdFu3