Skip to content

Rows and links open from home whichever tab is shown; every shown failure is saved - #2119

Merged
trissim merged 1 commit into
mainfrom
fork-qt-participants-welcome
Nov 18, 2026
Merged

trissim merged 1 commit into
mainfrom
fork-qt-participants-welcome

Conversation

@trissim

@trissim trissim commented Nov 18, 2026

Copy link
Copy Markdown

Tristan, on the phone: "some failure about a welcome screen", with nothing under logs/errors.

What it was. The warning Thread navigation: Thread origin for 'welcome' is no longer current; row ignored. Every row tap and link opens a thread from home (TargetOpen, owner welcome). The captured origin also held the selected tab, and was compared again after an await. So a second tap while the first opening mounted (or one tap a phone delivers twice) was dropped with that warning. Warnings were never saved, so the phone kept no trace.

Reproduced on the desktop with the phone's own toad.json (both bars at the bottom) and the new participants drive: open #comms, tap a thread row twice 50 ms apart. Before the fix: notices: [('WARNING', "Thread navigation: Thread origin for 'welcome' is no longer current; row ignored.")] saved errors: []. After: no notice, one tab for the thread.

Changes

  • client/session_scope: an origin answers what must stay unchanged while a thread opens from it (opening_standing). A view origin needs its tab still shown. HomeSessionOrigin needs nothing, since home opens rows whichever tab is shown. Textual's WelcomeScreen and Qt's QtWelcomeOrigin both inherit it. thread_navigation.ThreadOrigin captures that answer instead of app.selected_mode.
  • client/host, paths: every failure shown is now saved, through one writer (paths._save_report).
  • client/conversation: a channel with no active member reads 0 active, not 0 active · .
  • tools/qt_drive:
    • ParticipantSteps records every notice from the first frame (Scenario.before_open), taps the N active line open, then a member, then closed by finger, and taps a row twice. All lookups use open path: view settings class set up after startup; rows laid out once; qt_drive waits for sidebar rows #2112's waiting found/channel_row/thread_row.
    • New participants scenario, which fails on any warning or error notice, and on one that wasn't saved.
    • The shipped scenario that check.sh runs now taps #comms' activity line and taps the thread row twice. It fails on any warning or error notice in those steps.

The participants tap itself, which Tristan mentioned, works. It shows ▶ 1 active · claude-a, opens to one row per member, and closes, with no notice.

Gates on 36f8032 (run once, one at a time)

  • ratchet: bare Qt classes 21/21, copies 0. shadow_check 0. glyph_check 0.
  • participants (phone layout): exit 0, notices: [] saved: [], one tab after the double tap.
  • history (phone layout): exit 0.
  • tools/android/check.sh with PYTHONFAULTHANDLER=1: exit 0. The shipped app ran every view kind and bound key, 3-channel-activity and 4-thread-tapped-twice posted no notice, and no error file was written. That's with qt themes: Qt offers only the schemes it can draw; one failing setting no longer stops a start #2115's ansi-dark start, whose not-offered warning now lands in logs/warnings.
  • arrival: exit 0 on the pre-rebase head (ff343bc09, same change except the warnings folder). After the rebase it timed out at welcome rows on this branch and on plain main alike. The host's OOM at 04:53 took down the systemd user manager, and the live bus with it (systemctl --user: connection refused). It needs a rerun once the bus is back.

🤖 Generated with Claude Code

https://claude.ai/code/session_01RnH6dT7wdh7i4tjJZQdFu3

…lure is saved

Tristan, on the phone: "some failure about a welcome screen". It was the warning
"Thread navigation: Thread origin for 'welcome' is no longer current; row ignored."
Every row and link opens a thread from home (TargetOpen, owner WELCOME), but the
captured origin also held the selected tab, so a second tap while the first opening
mounted (or one tap a phone delivers twice) was dropped with that warning. Reproduced
with the new `participants` drive on the phone's own layout.

- client/session_scope: an origin answers what must stay unchanged while a thread
  opens from it (opening_standing): a view needs its tab still shown; HomeSessionOrigin,
  which Textual's WelcomeScreen and Qt's QtWelcomeOrigin now inherit, needs nothing.
  thread_navigation captures that answer instead of the selected tab.
- client/host, paths: show_error given text or a Core refusal now saves it under
  logs/errors like every other error notice, and show_warning saves its text under
  logs/warnings (paths.save_warning; one writer for both), each with the stack that
  reported it. Nothing was saved for this warning. Warnings keep their own folder because
  logs/errors is what fails shipped_run (#2115). Textual's agent-failure notice goes
  through show_error instead of notify.
- client/conversation: a channel with no active member says "0 active", not "0 active · ".
- tools/qt_drive: ParticipantSteps (notices recorded from the first frame, the activity
  line tapped open/member/closed by finger, a row tapped twice); the `participants`
  scenario; the `shipped` scenario that check.sh runs now taps #comms' activity line
  and taps the thread row twice, failing on any warning or error notice in those steps.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01RnH6dT7wdh7i4tjJZQdFu3
@trissim
trissim merged commit 5e3897a into main Nov 18, 2026
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants