Repository navigation
Rows and links open from home whichever tab is shown; every shown failure is saved - #2119
Merged
Merged
Conversation
…lure is saved Tristan, on the phone: "some failure about a welcome screen". It was the warning "Thread navigation: Thread origin for 'welcome' is no longer current; row ignored." Every row and link opens a thread from home (TargetOpen, owner WELCOME), but the captured origin also held the selected tab, so a second tap while the first opening mounted (or one tap a phone delivers twice) was dropped with that warning. Reproduced with the new `participants` drive on the phone's own layout. - client/session_scope: an origin answers what must stay unchanged while a thread opens from it (opening_standing): a view needs its tab still shown; HomeSessionOrigin, which Textual's WelcomeScreen and Qt's QtWelcomeOrigin now inherit, needs nothing. thread_navigation captures that answer instead of the selected tab. - client/host, paths: show_error given text or a Core refusal now saves it under logs/errors like every other error notice, and show_warning saves its text under logs/warnings (paths.save_warning; one writer for both), each with the stack that reported it. Nothing was saved for this warning. Warnings keep their own folder because logs/errors is what fails shipped_run (#2115). Textual's agent-failure notice goes through show_error instead of notify. - client/conversation: a channel with no active member says "0 active", not "0 active · ". - tools/qt_drive: ParticipantSteps (notices recorded from the first frame, the activity line tapped open/member/closed by finger, a row tapped twice); the `participants` scenario; the `shipped` scenario that check.sh runs now taps #comms' activity line and taps the thread row twice, failing on any warning or error notice in those steps. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01RnH6dT7wdh7i4tjJZQdFu3
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tristan, on the phone: "some failure about a welcome screen", with nothing under logs/errors.
What it was. The warning
Thread navigation: Thread origin for 'welcome' is no longer current; row ignored.Every row tap and link opens a thread from home (TargetOpen, ownerwelcome). The captured origin also held the selected tab, and was compared again after an await. So a second tap while the first opening mounted (or one tap a phone delivers twice) was dropped with that warning. Warnings were never saved, so the phone kept no trace.Reproduced on the desktop with the phone's own toad.json (both bars at the bottom) and the new
participantsdrive: open #comms, tap a thread row twice 50 ms apart. Before the fix:notices: [('WARNING', "Thread navigation: Thread origin for 'welcome' is no longer current; row ignored.")] saved errors: []. After: no notice, one tab for the thread.Changes
client/session_scope: an origin answers what must stay unchanged while a thread opens from it (opening_standing). A view origin needs its tab still shown.HomeSessionOriginneeds nothing, since home opens rows whichever tab is shown. Textual'sWelcomeScreenand Qt'sQtWelcomeOriginboth inherit it.thread_navigation.ThreadOrigincaptures that answer instead ofapp.selected_mode.client/host,paths: every failure shown is now saved, through one writer (paths._save_report).show_errorgiven text or a Core refusal (ToolRefusedError) now saves underlogs/errors, like every other error notice. A refusal's notice stays one line and isn't sent to the crash sink.show_warningsaves its text with the reporting stack underlogs/warnings(paths.save_warning). Warnings get their own folder becauselogs/errorsis what failsshipped_run(qt themes: Qt offers only the schemes it can draw; one failing setting no longer stops a start #2115), and a warning isn't a failure.show_errorinstead of a barenotify.apply_setting_effectalready reports throughshow_error, so there's one owner.client/conversation: a channel with no active member reads0 active, not0 active ·.tools/qt_drive:ParticipantStepsrecords every notice from the first frame (Scenario.before_open), taps theN activeline open, then a member, then closed by finger, and taps a row twice. All lookups use open path: view settings class set up after startup; rows laid out once; qt_drive waits for sidebar rows #2112's waitingfound/channel_row/thread_row.participantsscenario, which fails on any warning or error notice, and on one that wasn't saved.shippedscenario thatcheck.shruns now taps #comms' activity line and taps the thread row twice. It fails on any warning or error notice in those steps.The participants tap itself, which Tristan mentioned, works. It shows
▶ 1 active · claude-a, opens to one row per member, and closes, with no notice.Gates on 36f8032 (run once, one at a time)
participants(phone layout): exit 0,notices: [] saved: [], one tab after the double tap.history(phone layout): exit 0.tools/android/check.shwithPYTHONFAULTHANDLER=1: exit 0. The shipped app ran every view kind and bound key,3-channel-activityand4-thread-tapped-twiceposted no notice, and no error file was written. That's with qt themes: Qt offers only the schemes it can draw; one failing setting no longer stops a start #2115's ansi-dark start, whose not-offered warning now lands inlogs/warnings.arrival: exit 0 on the pre-rebase head (ff343bc09, same change except the warnings folder). After the rebase it timed out atwelcome rowson this branch and on plain main alike. The host's OOM at 04:53 took down the systemd user manager, and the live bus with it (systemctl --user: connection refused). It needs a rerun once the bus is back.🤖 Generated with Claude Code
https://claude.ai/code/session_01RnH6dT7wdh7i4tjJZQdFu3