Repository navigation
Conversation
…eight Every pop-up Toad opens (the application menu, a message's and a sidebar row's menu, the bus-connect choices, a sort choice) is the window's one QtMenu. It is a child of the window in no layout, placed at the anchor it was asked from (under it, or above it where there is no room below), so opening or closing it moves nothing underneath. A tap outside closes it and does nothing else (the press and its release are eaten); Escape closes it ahead of any shortcut bound to Escape; Back closes it through go_back. The sort choice's QMenu (a top-level popup window, the EGL hazard on Android) is gone; it lists its choices in the same menu under its button. The menu is one surface: the float tone, one rule-coloured border, flat rows with the float hover tone and muted descriptions. The per-row button boxes and the chrome frame around it are gone. It is the window's width up to 420 px and scrolls only when its rows do not fit. Every button in the composer's box row is the box's one-line height, pinned to the bottom of a taller box (Composer.fit_buttons). tools/qt_drive.py menu_float checks each menu changes no pixel outside it, the outside tap and Escape, the anchors, the composer's button, and quits with the menu open. Depends on the contrast fork's ui_theme roles (FloatToneColour, FloatHoverToneColour, RuleColour). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01RnH6dT7wdh7i4tjJZQdFu3
Author
|
Merged as part of #2130: this branch was rebased onto main and gated together with the other UI branches, since they edit the same lines. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tristan, on the phone: "The menu pop-up pushes things instead of floating, and it looks really atrocious: a box in a box in a box … instead of minimal and clean. And make the send button a little bigger: the same height as the input box, so they're aligned."
What was wrong (main, phone profile 412×915, offscreen)
QtMenuwas added to the window's chrome layout above the bar. Opening the app menu changed 121,308 pixels outside the menu: the conversation and the sidebar moved up.QMenu: a second, top-level pop-up, which is the EGL hazard on Android.What changed
QtMenu, floating. It's a child of the window in no layout, placed at the anchor it was asked from: under it, or above it where there's more room. It covers the application menu (under ≡), a message's menu (at the pressed row), a sidebar row's held menu (at the pressed point), the bus-connect choices (top), and a sort choice (under its button). Callers pass the anchor in the window's coordinates (offer_entries(entries, anchor);block_menu_requestednow carries the pressed point).go_back, as before.RuleColourline (radius 6). There's no shadow.QMenu/QActionimports inthread_comms_panel.pyare deleted.Composer.fit_buttons: every button in the box's row is the box's one-line height (editor one-line height + box padding + border) and at least as wide. Each is bottom-aligned, so it's level with a one-line box and pinned to the bottom of a taller one. A button another composer adds to that row, such as the file picker's Attach, gets the same sizing.Depends on
The contrast fork's
ui_themeroles:FloatToneColour,FloatHoverToneColour,RuleColour(andMutedColour). Rollout: ui-theme, then pyqt-reactive, then the runtime rebuild, then this PR. Every local run here put that branch'sui_themefirst on the path.check.shran on a scratch copy of the installed runtime with thatui_themein its site-packages.Evidence:
qt_drive.py menu_floatPhone profile, #comms on the live bus. Main vs branch:
I read the screenshots of main and the branch. On main the menu sits inside the bottom chrome with a button box per row and the conversation pushed up. On the branch it's one full-width rounded surface over the content with flat rows, and the page underneath is unchanged.
Gates, once on the final head
tools/android/check.shwithPYTHONFAULTHANDLER=1: rc 0. The shipped app ran every view kind and bound key on a scratch bus, with no fatal error or traceback.menu,chrome,feedbackandmenu_floatall exit 0, with 0 error files and 0 tracebacks.Expect to rebase over
fork-android-file-picker-2) adds Attach to the composer's box row.fit_buttonsalready sizes it, and the likely conflict is theframe_rowlines inComposer.__init__.history.py: only theblock_menu_requestedsignal and its emit changed.🤖 Generated with Claude Code
https://claude.ai/code/session_01RnH6dT7wdh7i4tjJZQdFu3