Skip to content

Qt-for-Android: parent QLabels in PlacementControl - #34

Merged
trissim merged 1 commit into
mainfrom
hotfix/sidebar-label-parent
Nov 17, 2026
Merged

trissim merged 1 commit into
mainfrom
hotfix/sidebar-label-parent

Conversation

@trissim

@trissim trissim commented Nov 17, 2026

Copy link
Copy Markdown
Contributor

Companion to toad PR #1909. Two chevron labels in PlacementControl.init were constructed without a parent, so on Qt-for-Android they briefly became top-level windows with their own EGL surface before row.addWidget() reparented them. The first-paint flush of the sidebar could then recurse into QAndroidPlatformOpenGLWindow::eglSurface() and trip the deadlock protector.

Pass self as parent at construction.

🤖 Generated with Claude Code

https://claude.ai/code/session_016gZLdupVQyBzHTmHBC9Cyn

The two chevron labels (_left, _right) were constructed without a
parent, so on Qt-for-Android they became top-level windows with their
own EGL surface in the brief window between construction and
row.addWidget(...) reparenting them. The first-paint flush of the
sidebar could then recurse into QAndroidPlatformOpenGLWindow::eglSurface()
and trip the deadlock protector.

Pass the enclosing PlacementControl as parent at construction.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_016gZLdupVQyBzHTmHBC9Cyn
@trissim
trissim merged commit bbe6f6b into main Nov 17, 2026
1 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant