Repository navigation
virtual rows: a scroll moves the pixels of what nothing floats over; only the covered bands repaint - #67
Merged
Conversation
…only the covered bands repaint Qt scrolls a viewport by moving its pixels and painting the strip that came into view, unless a sibling widget overlaps what it scrolls; then it repaints the whole viewport. Toad's history floats a pinned header, an overlay scrollbar and a jump button over its rows, so every frame of an arrival glide repainted every visible row's rich text (measured: the whole viewport per painted frame), which a phone cannot do at 120 Hz (Tristan, Pixel 8a, 2026-11-18). `VirtualRowView.scrollContentsBy` scrolls the largest rectangle of the viewport that none of its visible floating children covers (`floating_over`, `uncovered`), by its pixels, and repaints only the covered bands; with nothing floating over it, Qt's own scroll runs. Measured with toad's arrival drive at 120 Hz: a gliding frame repaints a median 5% of the viewport (was 100%). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01RnH6dT7wdh7i4tjJZQdFu3
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Qt scrolls a viewport by moving its pixels and painting only the strip that came into view, unless a sibling widget overlaps what it scrolls. Then it repaints the whole viewport.
Toad's history floats three widgets over its rows: a pinned header, an overlay scrollbar and a jump button. So every frame of an arrival glide repainted every visible row's rich text. Toad's
arrivaldrive measured this as 100% of the viewport repainted per frame at 120 Hz, which a phone can't keep up with (Tristan, Pixel 8a, 2026-11-18: "messages coming in is still stuttery, not 120fps").Change
VirtualRowView.scrollContentsByscrolls, by its pixels, the largest rectangle of the viewport that none of its visible floating children covers (floating_over,uncovered), and repaints only the covered bands. With nothing floating over the viewport, Qt's own scroll runs.QWidget.scroll(dx, dy, rect)moves no child widgets, so the floating ones stay put.Measured (toad
arrivaldrive, burst of 5, 120 Hz)Median share of the viewport repainted per gliding frame:
Test:
uncoveredfor a header band plus a scrollbar column, no covers, and a full cover. All 8 row-view tests pass.🤖 Generated with Claude Code
https://claude.ai/code/session_01RnH6dT7wdh7i4tjJZQdFu3