Skip to content

theming: phones keep the system's file picker; desktops keep the themed dialog - #66

Merged
trissim merged 1 commit into
mainfrom
native-dialogs-on-phones
Nov 18, 2026
Merged

trissim merged 1 commit into
mainfrom
native-dialogs-on-phones

Conversation

@trissim

@trissim trissim commented Nov 18, 2026

Copy link
Copy Markdown
Contributor

ThemeManager.apply_color_scheme set AA_DontUseNativeDialogs on every platform, so a native dialog never bypasses the theme. On Android (and iOS) the native file dialog is the system's picker, which is the only way into the phone's storage, photos and cloud drives. Qt's widget dialog there lists only the app's own directories. Toad's Android app showed that widget dialog for Attach (Tristan: "it shows the same file picker as if it was on desktop").

ThemeManager.native_dialogs_required(QGuiApplication.platformName()) names the platforms that keep native dialogs (android, ios), and the attribute follows it. Desktops are unchanged.

Tests: tests/test_native_dialogs.py (new, 3 tests) and tests/test_color_scheme_from_theme.py, 41 passed offscreen. Ruff is clean on the changed lines.

🤖 Generated with Claude Code

https://claude.ai/code/session_01RnH6dT7wdh7i4tjJZQdFu3

…ed dialog

apply_color_scheme set AA_DontUseNativeDialogs everywhere, so native dialogs never bypass the
theme. On Android (and iOS) the native dialog is the system's picker, the only way into the
phone's storage, photos and cloud drives; Qt's widget dialog there lists only the app's own
directories. ThemeManager.native_dialogs_required(platformName) names those platforms, and
the attribute follows it.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01RnH6dT7wdh7i4tjJZQdFu3
@trissim
trissim merged commit b63f123 into main Nov 18, 2026
3 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant