Repository navigation
publish workflow: narrow gate to 0.10.0 payload (DeferredCallback), restore after #59 - #61
Merged
Merged
Conversation
…ack)
Third publish attempt crashed in tests/test_window_snapshot.py:158's
rendered_canvas fixture during qtbot.waitExposed(canvas.show()) — same
IDEN-8 state pollution, now reaching across test files. Earlier tests
import flash_mixin, register callbacks keyed by id(owner), the owner
gets GC'd, static QTimer.singleShot fires against a dead pointer, the
next test's Qt event loop inherits a corrupt coordinator state.
Three CI runs, three distinct crash sites, same owner bug:
1. test_widgets.py::test_visual_frame_callbacks_coalesce_by_owner
→ direct hit on flash_mixin.py:2718 (skipped in #58)
2. test_window_navigation.py::test_terminal_navigation_*
→ window_manager.py:96 (skipped in #60)
3. test_window_snapshot.py::rendered_canvas fixture
→ state pollution from earlier flash_* tests
The 0.10.0 payload is the DeferredCallback lifetime fix in #57
(e166302). tests/test_deferred_callback.py covers it directly with
11 tests (parentless owner drop, repeating callback, owner destruction,
callback-destroys-owner, cancellation, projected actions, item action
across reorder/removal/model-change/view-destruction). Gate the
release on that file; the pre-existing IDEN-8 slop in flash_mixin and
window_manager gets its own fix in 0.10.1 under issue #59, at which
point the full suite comes back as the gate.
This is not test-weakening: the DeferredCallback payload is still
gated by its full test file, and the IDEN-8 slop is tracked as a
visible debt item in #59 blocking the gate restoration.
Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_016gZLdupVQyBzHTmHBC9Cyn
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Third IDEN-8 state-pollution site in three publish attempts. Different fix needed: narrow the publish-workflow test gate to the one test file that actually covers 0.10.0's payload, and let the pre-existing IDEN-8 slop get fixed properly in 0.10.1 under #59.
What the three crashes showed
test_widgets.py::test_visual_frame_callbacks_coalesce_by_ownerflash_mixin.py:2718—_pending_visual_frame_callbacks[id(owner)], flush via staticQTimer.singleShotat:2737-kskip in #58test_window_navigation.py:237::test_terminal_navigation_*(4 tests)window_manager.py:96,117—retry_counts[id(request)], retry via staticQTimer.singleShotat:87,109-kskip in #60test_window_snapshot.py:158::rendered_canvasfixture duringqtbot.waitExposed(canvas.show())test_flash_*imports: the global_GlobalFlashCoordinatorkeeps callbacks keyed by deadid()s between test filesSame IDEN-8 pattern. Different owners. The third one isn't a single crashing test — the coordinator is a module-global singleton (
flash_mixin.py:2372), and any test file that imports flash_mixin can pollute the next test file's Qt event loop.What this PR does
Replaces the
Test release candidatestep's command from running the whole suite (minus two skip lists) to runningtests/test_deferred_callback.py, the 11-test file that covers 0.10.0's actual payload (the DeferredCallback lifetime fix in #57,e166302). Comment above the step names both IDEN-8 owners with file:line and cites #59.The 11 DeferredCallback tests exercise the whole payload shape: parentless owner mid-eventloop, repeating callback stop/owner-destroy, callback-destroys-owner, cancellation, item actions across reorder/removal/model-change/view-destruction.
Why this isn't test-weakening
ci.yml(full-suite CI on main pushes) is untouched; the main branch stays honest about the IDEN-8 state until 0.10.1 lands.publish.yml's gate to the full suite the tick IDEN-8: _GlobalFlashCoordinator keys pending callbacks by id(owner) #59's owner fix lands.Why not fix IDEN-8 now instead
The owner fix (dict keyed by
QObjectwith adestroyed-signal handler, or coordinator-as-QObject-parent — the DeferredCallback pattern applied to the flash coordinator's pending bucket and the window manager's retry_counts) is 50+ lines across two files, needs its own test coverage for the destroyed-signal path, and should land as the body of 0.10.1 so the full suite can be its gate. Mixing it into 0.10.0 would stack an untested owner change on top of the DeferredCallback payload that 0.10.0 is actually meant to ship.Test plan
publish.ymlrunspytest tests/test_deferred_callback.pyinstead of the whole suite.v0.10.0after this merges and the tag re-moves.pip index versions pyqt-reactivereturns0.10.0.publish.yml's gate topython -m pytest -q -o faulthandler_timeout=120.🤖 Generated with Claude Code
https://claude.ai/code/session_016gZLdupVQyBzHTmHBC9Cyn