Skip to content

Delete implicit checkout discovery and duplicate consumer rewriting - #479

Merged
trissim merged 1 commit into
mainfrom
work/codex-live--P282--nominalrefactoradvisor
Nov 18, 2026
Merged

trissim merged 1 commit into
mainfrom
work/codex-live--P282--nominalrefactoradvisor

Conversation

@trissim

@trissim trissim commented Nov 18, 2026 •

Copy link
Copy Markdown
Contributor

Results

  • 87 passed, exit 0 across selected-source consumers, relocation ordering, annotations, hidden-import cuts and indexed scopes. The source-scope family applies actual moves and runs consumers.
  • Before repair, the unselected dependent sibling control failed: the move rewrote its import despite absence from the snapshot. The original failed output and harness errors remain in named scratch.
  • Repository guards: 72 passed, 9,134 deselected, exit 0. No timing or whole-host CPU claim.

Delete a competing source authority

A distribution dependency does not identify a particular versioned checkout or grant permission to edit a neighbour's branch. SourceBindingRelocatingModuleSymbolMoveOperationABC now obtains Python consumer rewrites only from the supplied CodemodSourceSnapshot/import graph through its existing ModuleNameRedirect. Existing manifest relocation remains unchanged.

Delete downstream_consumers.py (230 lines): sibling/UV discovery, recursive filesystem scans, dependency-name matching and an independent opaque Python text writer. This also removes the AST/text conflict when the same consumer was explicitly selected. No replacement scanner, registry or compatibility export.

Bounded guarantee

Explicitly selected consumer bindings follow the moved declaration, regardless of package dependency spelling. Unselected sibling checkouts stay unread/unwritten, even when their dependency matches, files are invalid, or a workspace entry is absent. Callers must select the actual consumers; this is not a claim to have migrated unknown external clients. Alias and module-object reads retain their runtime output; a hidden-import cut carries the selected consumer rewrite.

The ordered NRA plan patches the owner, removes its obsolete import, deletes every old declaration and dissolves the unused module. Simulation, reviewed diff and revision-checked application are retained under /home/ts/.cache/agent-scratch/codex-latency/relocation-consumer-scope/.

P282. Solo work; no other checkout was edited.

Installed delivery

Merged as 8160d8bf6505, installed with Core e7dfecb09322 and Toad e5eff11109a2 in runtime lock 83386afa894a8c9f. 14 installed-package scope controls passed, exit 0. Package metadata confirms NRA commit 8160d8b; installed source has no implicit scanner hook. Fresh native reply b54dd9cdac47 explicitly answers probe 91f01d07c590 (bus 23377 → 23376). No user window restart, replay or overall CPU saving claim.

The first install failed a GitHub HTTP/2 fetch before cutover; the ordinary retry finished in47 seconds, exit0. Both receipts remain retained.

CI is not globally green

Post-hoc boundary job135185401517 reports existing compact-scan failures in analysis.py:2110 (three context detectors without compact projections) and missing scan_status in the warm-cache control. Docs job135185401287 reports public_api.rst:1384 naming removed codemod_call_declarations and a later skip_if_no_key error. The stale docs reference exists on base0dae25ab; neither analysis.py nor these docs/tests changed here. These remain open work; no detector was dropped or coverage report weakened.

Publication first caught an allocation mismatch on the retained P118 tree. No forced adoption/reset/archive occurred; supported P282 allocation received the identical pushed commit, and this PR was opened from that owned tree. Independent acceptance is not claimed.

@trissim
trissim marked this pull request as ready for review November 18, 2026 22:35
@trissim
trissim merged commit 8160d8b into main Nov 18, 2026
1 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant