Repository navigation
fix(battery): invert charger_gpio_charging() to match BQ25616 STAT polarity - #181
Merged
Merged
Conversation
…larity STAT is open-drain. It is pulled LOW while charging. It goes HIGH on complete or sleep. It blinks at 1 Hz on fault. Source: TI BQ25616/616J datasheet and schematic checklist. This matches the existing doc for OD_CHARGER_FLAG_STATE_ACTIVE_LOW in include/opendisplay_structs.h:521. Datasheet: https://www.ti.com/lit/ds/symlink/bq25616.pdf Schematic checklist: https://e2e.ti.com/cfs-file/__key/communityserver-discussions-components-files/196/BQ25611D_5F00_BQ25616J_5F00_BQ25618_5F00_BQ25619_5F00_SchematicChecklist.pdf Fixes OpenDisplay#178
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
STAT is open-drain. It is pulled LOW while charging. It goes HIGH on complete or sleep.
It blinks at 1 Hz on fault.
Source: TI BQ25616/616J datasheet and schematic checklist.
This matches the existing doc for OD_CHARGER_FLAG_STATE_ACTIVE_LOW in include/opendisplay_structs.h:521.
Fixes #178