Skip to content

fix(battery): invert charger_gpio_charging() to match BQ25616 STAT polarity - #181

Merged
jonasniesner merged 1 commit into
OpenDisplay:mainfrom
cryptomilk:asn-wip
Nov 10, 2026
Merged

jonasniesner merged 1 commit into
OpenDisplay:mainfrom
cryptomilk:asn-wip

Conversation

@cryptomilk

@cryptomilk cryptomilk commented Nov 10, 2026 •

Copy link
Copy Markdown
Contributor

STAT is open-drain. It is pulled LOW while charging. It goes HIGH on complete or sleep.
It blinks at 1 Hz on fault.
Source: TI BQ25616/616J datasheet and schematic checklist.

This matches the existing doc for OD_CHARGER_FLAG_STATE_ACTIVE_LOW in include/opendisplay_structs.h:521.

Fixes #178

…larity

STAT is open-drain. It is pulled LOW while charging.
It goes HIGH on complete or sleep.
It blinks at 1 Hz on fault.
Source: TI BQ25616/616J datasheet and schematic checklist.

This matches the existing doc for OD_CHARGER_FLAG_STATE_ACTIVE_LOW
in include/opendisplay_structs.h:521.

Datasheet: https://www.ti.com/lit/ds/symlink/bq25616.pdf
Schematic checklist:
https://e2e.ti.com/cfs-file/__key/communityserver-discussions-components-files/196/BQ25611D_5F00_BQ25616J_5F00_BQ25618_5F00_BQ25619_5F00_SchematicChecklist.pdf

Fixes OpenDisplay#178
@jonasniesner
jonasniesner merged commit 2cd03db into OpenDisplay:main Nov 10, 2026
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Charge-state polarity: header doc and charger_gpio_charging() disagree

2 participants