Repository navigation
OpenConceptLab/ocl_online#201 | Saved endpoint tokens aren't returned by the API - #130
Merged
Merged
Conversation
…: the Mapper reads has_token, asks for a custom algorithm's key each session, and keeps tokens out of copies and run snapshots
…ow and goes on, lookup token warning, http(s) URL rule matches the API, saved-token URL kept locally, explicit remove
snyaggarwal
commented
Nov 12, 2026
snyaggarwal
left a comment
Contributor
Author
There was a problem hiding this comment.
Reviewed with OpenConceptLab/oclapi2#991 at the current heads. One UI finding below. I did not run tests or lint locally, per request.
…n URL blur; remove action shown with the auth error
snyaggarwal
marked this pull request as ready for review
November 12, 2026 08:22
snyaggarwal
commented
Nov 12, 2026
snyaggarwal
left a comment
Contributor
Author
There was a problem hiding this comment.
Rereviewed with OpenConceptLab/oclapi2#991. The earlier P3 is addressed: URL blur skips unauthenticated verification for a saved token, and the removal action remains visible alongside an authentication error. I found no further actionable findings or nits in this pass. I did not run tests or lint locally, per request.
…etail fetch uses isAbsoluteURL; blank token keeps a saved one; lookup token only to its own origin
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs OpenConceptLab/ocl_online#201. Goes with OpenConceptLab/oclapi2#991, which makes map project tokens write-only: the API stores them apart and returns
has_token: truein their place.Changes
has_token, as the API drops a token whose URL changes.has_token.has_token.buildConfigSnapshotleaves out every token from the run snapshot.tokenScope.js:isOCLAPILookupURL,needsSessionToken,withoutTokens. New strings in en, es, pt-BR and zh.Not in this PR
Tests
npm test: 662 pass, including new tests for the helpers and the snapshot.npm run eslint: clean.🤖 Generated with Claude Code