Repository navigation
[FIX] compare maintainer logins case-insensitively - #370
Merged
Merged
Conversation
AungKoKoLin1997
force-pushed
the
master-fix-maintainer-case-insensitive
branch
from
November 4, 2026 06:50
907d415 to
84b81b8
Compare
pedrobaeza
approved these changes
Nov 4, 2026
AungKoKoLin1997
force-pushed
the
master-fix-maintainer-case-insensitive
branch
from
November 10, 2026 03:53
65e296a to
ea3475d
Compare
Contributor
Author
|
@pedrobaeza I pushed a couple of changes after your approval, squashed into the same commit:
|
pedrobaeza
reviewed
Nov 10, 2026
GitHub logins are case-insensitive, but the maintainers check compared the commenter's login with the manifest entries case-sensitively, so a maintainer declared as "aungkokolin1997" was refused when commenting as "AungKoKoLin1997". The mention task had the same mismatch and pinged such a maintainer on their own PR. Assisted-by: Claude Opus 5.5
AungKoKoLin1997
force-pushed
the
master-fix-maintainer-case-insensitive
branch
from
November 10, 2026 07:25
ea3475d to
39f75fa
Compare
pedrobaeza
approved these changes
Nov 10, 2026
kanda999
approved these changes
Nov 13, 2026
Contributor
|
This PR has the |
Contributor
Author
|
@pedrobaeza Could you please merge the PR? |
Member
|
This should be merged and deployed by one of the library maintainers. |
Contributor
Author
|
@sbidoul Could you please take a look at this PR? |
Member
|
Deployed on OCA server |
Contributor
Author
@sbidoul Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GitHub logins are case-insensitive, but the merge bot compared the commenter's login with the manifest
maintainersentries case-sensitively.For example, in OCA/account-analytic#1000,
mrp_stock_analyticdeclaresaungkokolin1997as maintainer, but/ocabot mergefromAungKoKoLin1997was refused.This lowercases both sides in
is_maintainerandis_maintainer_other_branches.@qrtl