Repository navigation
Target net11.0, update dependencies and use NuGet trusted publishing - #5
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Adds net11.0 next to net10.0 and moves to GenericReader 3.0.0 and OffiUtils 4.0.0. On net11.0 the tests no longer register the ZstdSharp decompressor, so they use the default Zstd decompressor from OffiUtils. PublishAot is dropped because it has no effect on a library; IsAotCompatible stays. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Publishing moves to its own job that logs in through NuGet/login with the GitHub OIDC token, so only that job gets id-token: write and the NUGET_API_KEY secret is no longer used. A new workflow builds and tests pull requests against master. Tests run through dotnet test on Microsoft.Testing.Platform, selected in global.json. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a
net11.0target next tonet10.0, updates dependencies (GenericReader 3.0.0, OffiUtils 4.0.0, test packages) and bumps the package to 3.4.0. Pushing to master publishes it.Build
PublishAotis removed fromDirectory.Build.propsbecause it does nothing for a library.IsAotCompatiblestays.net11.0the tests stop registering the ZstdSharp decompressor and use the default Zstd decompressor from OffiUtils (#if !NET11_0_OR_GREATERinTests.cs).CI
publishjob. It downloads the packed artifact and gets a short-lived API key fromNuGet/loginusing the GitHub OIDC token. Only that job hasid-token: write; restore, build and tests run withcontents: read.test.ymlbuilds and tests pull requests against master.dotnet teston Microsoft.Testing.Platform, whichsrc/global.jsonselects.Other
.gitattributeswith* text=auto. Files in the index were already LF, so no files are renormalized.Before merging: nuget.org needs a trusted publishing policy for the
Fortnite-APIaccount that coversNotOfficer/Usmap.NETandbuild-test-publish.yml. Without it the login step fails and 3.4.0 is not published. After that, theNUGET_API_KEYsecret can be deleted.Validation: I ran
dotnet build -c Release(0 warnings) anddotnet test -c Releaselocally with the .NET 10.0.102 and 11.0.100 SDKs. All 21 tests passed on each TFM (42 total). I haven't run the publish job.🤖 Generated by Opus 5.5 with Claude Code in T3 Code