Skip to content

NethVoice: NethHotel pages and room actions fail #8319

Open
nethesis/ns8-nethvoice
#1204

Description

@Stell0

Steps to reproduce

  1. Enable NethHotel on NethVoice 1.8.1 and sign in to FreePBX.
  2. Open /freepbx/hotel/rooms.php before configuring any rooms.
  3. Configure test rooms, then use Options, Groups, room alarms, cost reports, extra charges, and the History filter.

Expected behavior

Every NethHotel section loads, including when no rooms are configured. Room and group actions complete, saved settings remain intact, and closing an alarm dialog also closes its calendar.

Actual behavior

The empty Rooms page fails with Trying to access array offset on null in loadRooms(). Options can stop rendering when settings are missing. Requests for translations, new groups, alarm/group details, reports, and unfiltered history fail because optional parameters are read as required values.

Further problems include undefined fields in the group editor, an error when removing an extra charge, missing group status and cleaning controls when database values are integers, and an alarm calendar remaining over later dialogs after its parent dialog closes.

Components

  • NethVoice 1.8.1
  • FreePBX 17.0.33.2
  • PHP 8.3

Validation

The proposed fixes were tested with Playwright across all seven NethHotel sections, including create/edit/delete flows, room and group check-in/out, alarms, cleaning, guest details and language, extra charges, current and historical cost reports, printing, and Options save/reload. Temporary test data was removed and original hotel settings were restored. SIP call delivery and external property-management-system communication were not tested.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

nethvoiceBug or features releted to the NethVoice project

Type

Projects

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions