Repository navigation
Add opt-in Windows Korean hardware keyboard support - #102
zeberity123 wants to merge 1 commit into
Conversation
|
I'm open to merging after openparsec v2, meanwhile, is this PR reading for merge? |
|
@zeberity123 thanks for the code, but this draft at the moment conflcts with main, and 2.0 will change how settings are stored and a lot of ParsecViewController |
|
@zeberity123 2.0.0 is out, please rebase and mark your PR ready when you want a review |
Adds Windows Korean Keyboard under Settings > Keyboard, off by default. When enabled, physical keys are read through GameController (UIKit fallback) and Hangul/LANG1, Right Alt, Ctrl+Space and Shift+Space are translated into a single Right Alt tap for Korean Microsoft IME. Accompanying modifiers are released immediately and ignored until their physical key-up. Also adds a touch 한/영 button and an optional backtick mapping. Rebased onto 2.0.0: settings live in SettingsStore, and the mode is re-applied when in-stream settings close, so no reconnect is needed. Router event sequences are covered by Tests/main.swift. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
9ed2295 to
db020b5
Compare
|
Thanks for the heads-up, and sorry for the slow reply! I've rebased onto 2.0.0 as a single commit. The settings now use I'm keeping this as a draft until I've retested the 2.0 build on my iPad (LTBK21 → Windows 11). I'll mark it ready for review after that. |
An SDIC Korea LTBK21 connected to an iPad did not reliably toggle the Windows host's Korean IME. Translating the language shortcut to Right Alt enabled switching, but keeping its accompanying Ctrl held until the keyboard's delayed key-up could affect subsequent typing.
This adds Windows Korean Keyboard, off by default, under Settings > Keyboard. When enabled, it uses GameController physical keyboard events with a UIKit fallback and translates Hangul/LANG1, Right Alt, Ctrl+Space, and Shift+Space into a single Right Alt tap. Hardware language shortcuts release accompanying modifiers immediately. Consumed modifiers remain released until physical key-up, and stale UIKit flags cannot turn the next ordinary Space into another language toggle.
It also provides a touch 한/영 button and an optional backtick mapping, off by default. Users should select Korean Microsoft IME with Korean keyboard (101-key) Type 1 on Windows. Korean mode repurposes Right Alt and overrides Option-as-Command; disabling it preserves the existing input path.
Validation:
The existing release workflow, bundle identifier, and download links are unchanged. The Caps Lock Esc/F-key mapping is kept in a separate follow-up.
The UIKit text-duplication guard uses a 150 ms window after physical keyboard events. The reported mixed-keyboard test passed, but this is not a claim of compatibility with every keyboard or iPadOS input source.