Repository navigation
chore: move to node 26 - #471
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
No linked issue: the team asked to move every repo to Node 26.
Moves this repo to Node 26, the version the engine, cli, loader and editor already require (
engines.node: "26").Changed files:
flake.nix.nvmrcand everyengineswere already on 26; this aligns the Nix dev shell.docs and docs-private stay on Node 24 for now: Mintlify's
mintrefuses Node 25 and later.How do you test this PR?
With Node v26.7.0:
pnpm install --frozen-lockfileandpnpm run lintpass. The engine build and tests were not run: the diff isflake.nixonly.The
flake.nixchange, where there is one, was not run:nixisn't installed on the machine used. Ifnix developfails, the locked nixpkgs is too old fornodejs_26: runnix flake update nixpkgs.Merge danger
Low. Only the Nix dev shell changes; no package is released.
Follow-up issues
None.
Quality gate
Small diff: one
reviewercovered all lanes.