You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Drop unused cuRAND and cuSOLVER dependencies - #2309
No cuOpt library or the Java JNI library uses either one.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Signed-off-by: Ramakrishna Prabhu <ramakrishnap@nvidia.com>
No actionable comments were generated in the recent review.
Walkthrough
The change updates CUDA library dependency and packaging settings for Python wheels and the Java JAR. It removes selected cuRAND and cuSolver components, paths, and exclusions, and updates Java linking, bundling, verification, and preload configuration. The routing wheel exclusion list adds libcudss.
Changes: Python wheel configuration
Layer / File(s)
Summary
Toolkit components and RPATH dependencies.yaml, python/libcuopt_mathopt/pyproject.toml, python/cmake/cuopt_wheel_build.cmake
CUDA Toolkit specifications remove the curand and cusolver components. The shared wheel RPATH list removes their library paths.
Wheel repair exclusions ci/build_wheel_*.sh
The wheel repair exclusion lists remove libcurand.so.* and libcusolver.so.*. The routing wheel list adds libcudss.so.*.
The static Java build drops CUDA::cusolver. JAR packaging no longer excludes libcusolver from companion bundling, and dependency verification no longer accepts libcusolver.so or libcurand.so as external. The loader no longer preloads libcusolver.so. The quick-start note names libcusparse instead of libcusolver.
No merge-blocking failure was identified, though artifact-level dependency validation remains outstanding.
Security architecture risk: Low · up to e8076
The changes remove explicit dependency requirements and narrow Java's external-library exceptions without demonstrating a new security bypass. Risk remains bounded, but the produced packages and their transitive native dependencies were not available to confirm end-to-end behavior.
Retained concerns
No architecture-level concerns identified.
Security review details
Security Blast Radius
inferred — The Java security-sensitive outcome is native code execution within the consuming JVM. Companion provenance remains dependent on the build environment and packaged resources; the changed lists do not establish a newly attacker-controlled input or increased execution privilege.
Trust Boundaries and Controls
observed — Java narrows, rather than widens, the external-dependency allowlist. Existing extraction controls reject a preexisting symlink or mismatched directory owner. These controls predate the PR and are not evidence that every deployment's filesystem or native search path is trustworthy.
Resilience and Maintainability Implications
observed — Existing extraction failures propagate instead of silently falling back to an external JNI library. Resource writes use temporary sibling files with cleanup, while existing same-size files are reused across runs. This retry and shared-cache behavior is unchanged; actual newly bundled cuSOLVER content was unavailable to establish additional exposure.
Pre-merge checks: 5
Check name
Status
Explanation
Title check
The title clearly summarizes the removal of unused cuRAND and cuSOLVER dependencies, which is the main change.
Docstring Coverage
No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentat…
Linked Issues check
Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check
Check skipped because no linked issues were found for this pull request.
Description check
The description states that cuOpt does not call cuRAND or cuSOLVER and identifies them as dependencies from RAFT. This matches the dependency removals in the changeset.
Full details: Docstring Coverage
Explanation
No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 0 functions across 3 files. (4 skipped: 4 unsupported.)
Finishing Touches
Generate unit tests (beta)
Create a new PR
Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Included review availability: This review used your included allowance. Your plan provides up to 12 included reviews per hour; 11 remain after this review.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ramakrishnap-nv
added
improvement
Description
cuOpt declares, links, or bundles cuRAND and cuSOLVER in several places, but no cuOpt library calls either one. These are dependencies from raft.