Skip to content

ci: skip C++ and wheel jobs for skills asset-only changes - #2306

Merged
rapids-bot[bot] merged 2 commits into
NVIDIA:mainfrom
ramakrishnap-nv:ci/gate-skills-assets-docs
Nov 10, 2026
Merged

rapids-bot[bot] merged 2 commits into
NVIDIA:mainfrom
ramakrishnap-nv:ci/gate-skills-assets-docs

Conversation

@ramakrishnap-nv

@ramakrishnap-nv ramakrishnap-nv commented Nov 10, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

Changes under skills/**/assets/**, skills/**/resources/** or skills/**/BENCHMARK.md currently run the C++ and wheel pipelines, which is a waste of resources.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Signed-off-by: Ramakrishna Prabhu <ramakrishnap@nvidia.com>
@copy-pr-bot

copy-pr-bot Bot commented Nov 10, 2026

Copy link
Copy Markdown

Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually.

Contributors can view more details about this message here.

@ramakrishnap-nv
ramakrishnap-nv marked this pull request as ready for review November 10, 2026 15:02
@ramakrishnap-nv
ramakrishnap-nv requested a review from a team as a code owner November 10, 2026 15:02
@github-actions

github-actions Bot commented Nov 10, 2026 •

Copy link
Copy Markdown

CI Test Summary

✅ All 28 test job(s) passed.

@coderabbitai

coderabbitai Bot commented Nov 10, 2026 •

Copy link
Copy Markdown

Explain Change →

No actionable comments were generated in the recent review.

Walkthrough

Four test groups in the pull request workflow now exclude skill assets, resources, and BENCHMARK.md files from their changed-file filters.

Changes: CI changed-file filters

Layer / File(s) Summary
Test-group path exclusions
.github/workflows/pr.yaml
The changed-file filters for the C++, C++ routing, C++ MathOpt, and Python wheel test groups now exclude skill assets, resources, and BENCHMARK.md files.

Estimated code review effort: 2 (Simple) | ~5 minutes

Change: Other

Possibly related issues

  • NVIDIA/cuopt issue 2258: The changed-file filters determine which C++ test jobs run. This change excludes skill asset and resource paths from those filters.

Possibly related PRs

  • NVIDIA/cuopt#2247: This PR split C++ tests into routing and MathOpt jobs. This change updates the filters used by those jobs.
  • NVIDIA/cuopt#2261: This PR added the routing and MathOpt changed-file groups. This change adds exclusions to those groups.
  • NVIDIA/cuopt#2293: This PR made ci/test-paths.yaml the source of truth for C++ test filters. This change updates exclusions in related filters.

Suggested labels: improvement, non-breaking

Merge Risk: Minimal · up to b2c28

This change stops the C++ and wheel test groups from running for skills asset, resource and benchmark-only PRs. Nothing found would break CI or product behavior. Some asset-only PRs will still run the conda C++ build because the asset tests need it, which costs CI time but does not block the merge.

Architecture risk: Low · up to b2c28

The changed surface does not map to a changed system, dependency edge, entrypoint, or external dependency.

Changed systems: None identified.

Architecture concerns
No architecture-level concerns identified.

Review details

Before / after behavior

  • observed — Modified behavior in .github/workflows/pr.yaml: The test_cpp changed-file filters add exclusions for skill assets, resources, and BENCHMARK.md.
  • observed — Modified behavior in .github/workflows/pr.yaml: The test_cpp_routing changed-file filters add exclusions for skill assets, resources, and BENCHMARK.md.
  • observed — Modified behavior in .github/workflows/pr.yaml: The test_cpp_mathopt changed-file filters add exclusions for skill assets, resources, and BENCHMARK.md.
  • observed — Modified behavior in .github/workflows/pr.yaml: The test_python_wheels changed-file filters add exclusions for skill assets, resources, and BENCHMARK.md.
Pre-merge checks: Passed 5

Check name Status Explanation
Title check Passed The title clearly states that CI skips C++ and wheel jobs for skills asset-only changes, which matches the main change.
Description check Passed The description explains that skills asset-only changes currently run the C++ and wheel pipelines and that the change avoids this unnecessary work.
Docstring Coverage Passed No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentat…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.)

Finishing Touches

Generate unit tests (beta)

  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Recent review info

Run configuration

  • Source mode: Auto
  • Repository: NVIDIA/cuopt
  • Branch: main
  • File: .coderabbit.yaml
  • Commit: 610774a
  • Layers: Repository YAML
  • Review profile: CHILL
  • Plan: Enterprise
  • Run ID: 56c09409-c503-4e32-a9f0-5d434c8cf677
Commits

Reviewing files that changed from the base of the PR and between 610774a and b2c28b9.

Files selected for processing: 1

  • .github/workflows/pr.yaml

Included review availability: This review used your included allowance. Your plan provides up to 12 included reviews per hour; 11 remain after this review.

@KyleFromNVIDIA KyleFromNVIDIA added non-breaking Introduces a non-breaking change improvement Improves an existing functionality labels Nov 10, 2026
@ramakrishnap-nv

Copy link
Copy Markdown
Collaborator Author

/merge

@ramakrishnap-nv

Copy link
Copy Markdown
Collaborator Author

/merge

@rapids-bot
rapids-bot Bot merged commit 46b8ed5 into NVIDIA:main Nov 10, 2026
95 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

improvement Improves an existing functionality non-breaking Introduces a non-breaking change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants