Skip to content

Redesign deploy output into phased, scannable, failure-aware blocks - #908

Merged
elliotBraem merged 5 commits into
mainfrom
t3/improve-deploy-output-clarity
Nov 20, 2026
Merged

elliotBraem merged 5 commits into
mainfrom
t3/improve-deploy-output-clarity

Conversation

@efizzybot

Copy link
Copy Markdown
Collaborator

Summary

  • Introduce a shared deploy output vocabulary (▶ phase headers, … running, ✓ done, ✗ failed) applied consistently across Preflight → Build → Release → Publish → Verify → Promote.
  • Collapse the confusing release-leg/manifest-leg messages into one clear release transition (old version → new version) plus a verified release-pointer line.
  • Render transaction hashes as clickable nearblocks links (mainnet/testnet aware) in success summaries, failure context, and renderers instead of bare hashes.
  • Report boot-gate readiness in elapsed seconds/minutes instead of raw "attempt N"; timeout errors now state the deadline and the last failure.
  • Replace run-on deploy errors with structured failure blocks — what happened / why it matters / what to do / context — keyed off the failed leg's kind.
  • Route gas-prepayment and signing-key preflight reads through the FastNEAR free RPC (NEAR_READ_RPC_URL overrides), while keeping the pinned NEAR_RPC_URL for transaction broadcasts; skip warnings now name the endpoint and the real error.
  • Thread kind, txHash, and txUrl through the train error, handler, contract schemas, and CLI renderers; add a patch changeset and unit tests for the new helpers.

Testing

  • Full unit suite passes (1,814 tests); one inline snapshot updated for the renamed Upload phase.
  • Targeted near-signer, publish-preflight-order, and custody-signer tests pass (75 tests).
  • tsc --noEmit clean; Biome clean.
  • lint:effect not run locally (vendored repos/effect clone absent, pnpm run prepare not run in this environment); CI runs prepare before lint and the diff adds no Effect code.
  • fresh-init-dev integration test does not pass locally — it also fails on a clean tree (confirmed via stash); environmental and unrelated to this change.

Co-authored-by: elliotBraem 16282460+elliotBraem@users.noreply.github.com

- Add phase headers and a consistent ✓/…/✗ line grammar
- Link tx hashes to nearblocks; report boot-gate polls in elapsed time
- Render failures as structured what-happened / why-it-matters / what-to-do blocks
- Read publish preflight checks from FastNEAR free RPC via NEAR_READ_RPC_URL

Co-authored-by: elliotBraem <16282460+elliotBraem@users.noreply.github.com>
…nd CI logging

CI: emit the pin-rot ::warning:: on stdout (annotations never parse from
GITHUB_STEP_SUMMARY); rewrite the pnpm audit step around a severity-aware
report script (no more raw JSON dump, substring-severity grep, or green
infra failures); name the failing suite in the CI gate verdict plus a
step-summary table; fail mirror-images with an ::error:: naming the stale
target; fold docker build attempts and attach the failure tail; make the
release OIDC diagnostics step never silent.

CLI: bos dev reports a crashed composition audit instead of rendering
nothing; bos status carries the published-config-unreachable reason
through and renders the deployed-vs-served verdict (previously computed
and dropped); the parent check distinguishes nothing-published from an
unreachable registry; device-flow approvals print a Delegate key phase
header and 30s elapsed progress instead of dead air.
… warnings

The audit step wrote audit-output.json into the repo root and the Biome
step — running later in the same job — formatted-checked the fresh
artifact and failed. Write both audit artifacts to $RUNNER_TEMP instead.
Side note: the rewritten gate works — this run surfaced two real
high-severity undici advisories (patched in >=8.12.2 / >=7.30.1).

Also clears the pre-existing biome warnings biome ci reported on every
run (unused imports in handlers/types-gen.ts, clean.ts, upgrade.ts and
three unit tests) so annotations carry signal again.
@efizzybot
efizzybot force-pushed the t3/improve-deploy-output-clarity branch from c6e12b8 to e74e3e1 Compare November 19, 2026 23:45
ci-gate runs no checkout step (it is the 5-second needs-only verdict), so
the report script from .github/scripts was never present in its workspace
and the gate failed with MODULE_NOT_FOUND on every green run. The verdict
logic now runs inline via node -e; the standalone script is gone.
@elliotBraem
elliotBraem merged commit 74a8904 into main Nov 20, 2026
22 checks passed
@elliotBraem
elliotBraem deleted the t3/improve-deploy-output-clarity branch November 20, 2026 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants