Repository navigation
Conversation
When a new engine restores the games and the engine before it crashed (a Java or native crash, or an ANR, since the device last started, as ApplicationExitInfo records it on Android 11 and later), the UI offers once for that crash to open Report a problem. Nothing is sent: the player sees the report there and chooses whether to send it. Report, Not now or closing the dialog keeps the crash's time in the ui preferences, so a crash is offered once. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_016ujaeFyaqXXDx8xjoThE6J
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Brief overview of PR changes/additions
ApplicationExitInfoon Android 11+), the UI shows a dialog once for that crash: "Mudlet crashed", with Report and Not now.crashReportOfferedin theuipreferences, so each crash is offered only once.EngineCrash.kt.EngineStoppednow shares how it reads the app's recorded process exits.EngineCrashTest(JVM),CrashOfferTestandCrashOfferPseudoLocaleTest(instrumented, with accessibility checks, in en-XA and ar-XB).FakeEngineRulesets the crash check to "no crash", so other tests never see the dialog.Motivation for adding to Mudlet
Other info (issues closed, discussion etc)
libmudletand a Qt front-end Mudlet#9011scripts/check-strings.py; CI: https://github.com/Mudlet/android/pull/184/checks; bite (the crash check always finds no crash): https://github.com/Mudlet/android/actions/runs/44224151223; device-only: the realApplicationExitInforead after an actual engine crash. The tests replace that check with a hook, as they do forEngineStopped.🤖 Generated with Claude Code
https://claude.ai/code/session_016ujaeFyaqXXDx8xjoThE6J