Repository navigation
Search the game's text, as desktop's search box does - #179
Merged
Merged
Conversation
A search button in the game's top bar, or Ctrl+F, opens a bar over the main console that searches its scrollback as TConsole's search does: case ignored, the first search up from the bottom, each next one older or newer from the line the last one found, which the console scrolls to. Matches are drawn black on yellow while the bar is open. What the bar says (how many lines match once typing pauses, the line found, or that there is no more) is a polite live region for TalkBack. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_016ujaeFyaqXXDx8xjoThE6J
aapt2 refuses an unescaped ' in a string resource. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_016ujaeFyaqXXDx8xjoThE6J
…KeyDown Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_016ujaeFyaqXXDx8xjoThE6J
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Brief overview of PR changes/additions
TConsole::slot_searchBufferUp/Down): case ignored, the first search up from the bottom, each next one older (also the keyboard's search key, as desktop's Enter) or newer from the last line found, which the console scrolls to.TTextEditdraws them, while the bar is open.ScrollbackSearchin:protocol) is plain Kotlin with JVM tests;docs/architecture.mdgains "Searching the game's text".Motivation for adding to Mudlet
Other info (issues closed, discussion etc)
libmudletand a Qt front-end Mudlet#9011ScrollbackSearchTest(JVM, red against stubs first), ktlint,scripts/lint.sh strings; newConsoleSearchTestandSearchPseudoLocaleTest(en-XA, ar-XB); CI: https://github.com/Mudlet/android/actions/runs/44231871095; bite: https://github.com/Mudlet/android/actions/runs/44231881932; device-only: the search with a hardware keyboard's Ctrl+F on a real device.🤖 Generated with Claude Code
https://claude.ai/code/session_016ujaeFyaqXXDx8xjoThE6J