Repository navigation
Conversation
macOS users previously had exactly one install path: Homebrew building from source (which exists partly because the app links libopus dynamically from the Homebrew prefix). This adds a real download: WAIL.app inside a drag-to-Applications dmg. scripts/package-macos.sh builds the app (nolibopusfile, so libopus is the only non-system dylib), stages a standard bundle — Info.plist, icon from the frontend logo, CLAP plugins at Contents/lib where the first-launch installer finds them — copies any package-manager dylibs into Contents/Frameworks and rewrites the references to @executable_path (no dylibbundler dependency; a post-check fails the build if any Homebrew reference survives), ad-hoc signs inside-out, and wraps it in a UDZO dmg. Verified locally: the bundled binary launches with the Homebrew opus prefix hidden. release.yml gains a build-macos job wired into create-release like the other platforms (a failed mac build doesn't sink the release). The dmg is Apple Silicon only and unsigned — first launch is right-click, Open, same trade as the unsigned Windows build; Intel Macs stay on the Homebrew tarball. build.yml's build-macos job smoke-tests the script on PRs so a broken package script fails before release day.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds a real macOS download:
wail-macos-arm64-<version>.dmgcontainingWAIL.app, built by a newscripts/package-macos.shand abuild-macosjob inrelease.yml. Until now the only Mac install path was Homebrew building from source — which exists partly because the app links libopus dynamically from the Homebrew prefix.How
scripts/package-macos.sh --version X.Y.Z --plugins DIR --out DIR:-tags nolibopusfile(so libopus is the only non-system dylib)WAIL.app— Info.plist, icon rendered from the frontend logo, and the CLAP plugins atContents/lib(where the app's first-launch installer looks, via{exe}/../lib)Contents/Frameworksand rewrites references to@executable_path— hand-rolledinstall_name_tool, no dylibbundler dependency; a post-check fails the build if any Homebrew reference survivescodesign --verify --deep --strictVerified locally: mounted dmg,
codesign --verifyclean, and the bundled binary launches with the Homebrew opus prefix temporarily hidden (proving it loads libopus from inside the .app).Deliberate trades
notarytool) can be layered on later without changing anything else.CI
release.yml: newbuild-macosjob (macos-latest → plugins → package script → artifact), wired intocreate-release's needs/condition/files like the other platforms — a failed mac build doesn't sink the release.build.yml: the existingbuild-macosjob now smoke-tests the packaging script end-to-end on PRs, so a broken script fails before release day.Testing
go test ./...✅ ·go test -tags linkstub ./...✅ · relay tests ✅ ·scripts/tier2-e2e.shPASS ✅