Repository navigation
Own browser for web interfaces, and web pages in the tab - #8
Merged
Merged
Conversation
Settings » Web interfaces: the program of any Chromium browser (Brave, Vivaldi, Chromium, Opera) or Firefox browser (Firefox, LibreWolf, Waterfox, Zen ...), its kind recognised from the file name or chosen, the profile (own per connection in the data folder, own temporary, or the browser's normal one, which stays outside the tab) and own arguments. Firefox browsers start with -no-remote and their own profile so their window can be placed into the tab (MozillaWindowClass). Roadmap item 12 records what is still to try.
- Every HTTP/HTTPS connection opens in a tab by default (Settings » Web interfaces » Open every web interface in a tab); before, only connections with "Open in a tab" ticked did, the others opened a browser window. - The window to embed is also searched among the processes the started one launched (embed::descendants over a process snapshot), and the tab keeps looking for 20 s after the first process ends: launchers and browsers that hand over to a child no longer leave the page outside the tab. - --open web:URL for checks. Tried live with Edge: the page shows in the tab.
…outside The settings chapter names the new default (Open every web interface in a tab) and the questions chapter says what to check when a web page still opens in its own window. All five languages.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Web interfaces (HTTP/HTTPS connections) can open in your own browser, inside the tab.
src/app_web.rs): the program of any Chromium browser (Brave, Brave Origin,Vivaldi, Chromium, Opera) or Firefox browser (Firefox, LibreWolf, Waterfox, Zen …); the kind is recognised
from the file name or chosen; the profile (own per connection in the data folder, own temporary, or the
browser's normal one, which stays outside the tab); own arguments.
src/launch.rs:browser_family,web_profile_dir,web_args. Chromium browsers get--appand theirown
--user-data-dir; Firefox browsers-no-remote -profile <dir> -new-windowand the window classMozillaWindowClass.web_all_in_tab); before, only connections withOpen in a tab ticked did, the others opened a separate browser window.
src/embed.rs: the window to embed is also searched among the processes the started one launched(
descendantsover a Toolhelp snapshot, at most 256), andsrc/app.rskeeps looking for 20 s after thefirst process ends — launchers and browsers that hand over to a child now land in the tab too.
--open web:URLfor checks.rules), user guide in all five languages (settings chapter, protocols table, questions chapter), README,
German README, translations in
de,fr,it,uk.Tested
cargo fmt --check,cargo clippy --all-targets --locked -- -D warnings,cargo test --locked(41 tests; new: browser kind, arguments for both kinds, profile folders, process tree incl. loops and the
256 cap).
--open web:https://example.com— the page shows inside the tab(window picture taken).
Not tested
item 12.