Repository navigation
Agents: screenshot of any tab, typing into embedded PuTTY windows - #7
Merged
Merged
Conversation
- New control command "screenshot" (CLI: window screenshot, MCP: window_screenshot, answered as an image): a PNG of what a tab shows, including a PuTTY, Remote Desktop or VNC window embedded in it, where reading the tab has no text. The picture is taken from the window itself (PrintWindow), so a window lying on top is neither in the way nor in the picture. The file name must end in .png. - Typing reaches embedded PuTTY windows too: characters are posted to the window, the keyboard focus stays where it is. Enter goes as a key press, because PuTTY's own line editing shows a posted carriage return as ^M. Behind the same switch as typing into terminals; other embedded windows answer with an error that points to the screenshot. - The embedding check (--open embedtest:…) takes a program with arguments. - Roadmap: what Remote Desktop and VNC would need.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Agents could open an embedded PuTTY, Remote Desktop or VNC tab but neither see nor use it:
readonly returned the tab's label and typing was refused.Changes
screenshot(CLIwindow screenshot [index] [file.png], MCPwindow_screenshot, which answers with an image): a PNG of what a tab shows, embedded windows included. Taken from the window itself, so a window lying on top is neither in the way nor in the picture. The file name must end in.png.^M). Same switch as typing into terminals. Remote Desktop and VNC windows answer with an error that points to the screenshot.--open embedtest:…takes a program with arguments.Tested
-D warnings, 39 tests.-rawto a local test server) embedded in a tab, driven through the control channel: the screenshot shows the PuTTY window with the server's greeting; three typed lines, one with umlauts, arrived at the server byte for byte with their line ends; typing is refused while the switch is off; a file name not ending in.pngis refused; the home tab gives a picture too.Not tested