Skip to content

fix: scheduler should step more often - #407

Merged
stephantul merged 2 commits into
mainfrom
fix-scheduler
Nov 3, 2026
Merged

stephantul merged 2 commits into
mainfrom
fix-scheduler

Conversation

@stephantul

Copy link
Copy Markdown
Contributor

The scheduler accidentally only stepped once per epoch. Because almost all our training tests are run on relatively small datasets (i.e., 10k-100k items), this was missed, and looked like it was working. The new scheduler steps every validation step

@stephantul
stephantul requested a review from Pringled November 2, 2026 20:08
@greptile-apps

greptile-apps Bot commented Nov 2, 2026 •

Copy link
Copy Markdown

RetriggerView in GreptileConfidence Score: 4/5

[Medium impact] The change affects model training across the shared training workflows.

The PR appears safe to merge, with a non-blocking update needed to the training guide.

Reviews (1) · Last reviewed commit: "fix: scheduler should step more often" · Reviewed by Greptile

Comment thread model2vec/train/trainer.py Resolved
@codecov

codecov Bot commented Nov 2, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

Files with missing lines Coverage Δ
model2vec/train/trainer.py 99.08% <100.00%> (-0.05%) ⬇️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@stephantul
stephantul merged commit c4dd117 into main Nov 3, 2026
11 checks passed
@stephantul
stephantul deleted the fix-scheduler branch November 3, 2026 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants