Repository navigation
feat(personal): the personal briefing moves to the browser — second report on the same page, Qt shell keeps only the inspiration tab, "Jot an idea…" opens it (M4b item 2) - #89
Merged
Conversation
…剩灵感页,页上「记灵感…」开它(M4b 第二项) - reports:personal_briefing provider(同一张页:概要 / 用量(没有花费)/ 分区 / 详情一段:怎么连的、工具几轮、读了哪些文件、 pull 结果)、generate_briefing(工作 / 个人同用,老名字 generate_work_briefing 保留)、open_inspiration 动作(界面线程上开 Qt 窗口的灵感页,回 opened);provider 多给 actions[](副按钮) - PersonalController(open_report=, report_watched=):「查看」开浏览器、打开即读过、页面开着不冒提醒;Qt 窗口 WorkBriefingWindow(briefing_page=False) 只有灵感页 + 在 Obsidian 打开;open_inspiration() - app:_start_personal 接 open_report / report_watched,started / finished → publish_report;_panorama 登记 personal_briefing 与 open_inspiration - 页面:#actions 副按钮区,动作回 opened 在状态栏说一声;字表(记灵感…、工具几轮、已在肥鱼里打开);流程说明文案 - 路线图 M4b 第二项打勾;docs/personal-assistant「窗口与岛」改写;docs/config-panorama 报告页;CHANGELOG Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Roadmap M4b, item 2: the personal briefing is now read in the browser on the same report page as the work briefing (
/report/personal_briefing): summary, usage chips (no cost — it is the user's own key), one card per section with filters and tick-off, and a one-paragraph "How this run went" (how it connects, tool rounds, files read, whethergit pullsucceeded). The island's person icon and the alert's "View" open the page; opening counts as read and an open page suppresses the new-briefing alert. The Qt window stays only as a shell for the inspiration tab plus "Open AI-Base in Obsidian", and the page gets a second button, "Jot an idea…", which opens that window through the panorama's action channel. Pages keep not knowing the feature: the provider just fills the same fields, plus a genericactions[]for side buttons.What changed and why
pet/panorama/reports.py:personal_briefing(service_of, config)provider (fields identical to the work briefing's;busy_textnames the model and effort;settings_focus="personal");personal_details(briefing)(connection line,turns+ files read as a list,pull_notein red);generate_briefing(generic regenerate,generate_work_briefingkept as an alias);open_inspiration(controller_of)→opened/unavailable;usage()drops a zero cost;generated_line(generated_at, key)so the personal page has its own "generated by your own Claude" line.pet/personal_ui.py:PersonalController(open_report=, report_watched=)— "view" opens the browser (bubblebriefing.bubble.page_failedif the server cannot start),open_inspiration()opens the Qt shell on its inspiration tab, the shell isWorkBriefingWindow(briefing_page=False)when the browser path exists,_refresh_windowand the alert logic respect the page; without the callbacks the old two-tab window is unchanged (existing tests).pet/app.py:_start_personalwiresopen_report/report_watchedand publishes the report onstarted/finished;_panorama()registerspersonal_briefing, the regenerate dispatcher now covers both reports, and theopen_inspirationaction.pet/panorama/page/report.html|js|css:#actionsside-button area (.alt .btn), one click path for all buttons; anopenedanswer showsreport_action_openedin the status line and re-enables the button;render.REPORT_KEYSgains the string.pet/locale/zh.json,en.json:personal.button.inspiration(+_hint),personal.trace.rounds,personal.generated,panorama.ui.report_action_opened; the settings flow tooltip's steps 1 and 3 now describe the browser page.docs/personal-assistant.md(module table, "窗口与岛" rewritten),docs/config-panorama.md(report page: two reports,actions[], the two actions),docs/roadmap.md(M4b item 2 ticked),CHANGELOG.md.tests/test_personal_report_page.py(new, 6: provider fields / usage without cost / sections / details; busy, error, pull note, no service; action dispatch by report name incl.opened; controller browser path, page-failed bubble, no alert while watched, Qt shell with only the inspiration tab + the action opening it);test_panorama_report_page.py(+1: side buttons and theopenedanswer);test_panorama_entry.py(registrations: two reports, three actions).Performance
Same code paths as the work briefing page (measured in #85 / #88:
markdown.render0.5 ms,split_sections0.2 ms on a 12 k-char briefing).personal_detailsis a few string joins over at most a handful of file names. No new requests, threads, disk or network; the side button is one POST per click, answered on the GUI thread like "Regenerate". Steady state zero: the provider runs only when a page asks or when a briefing starts / finishes and a page has asked before.Real-machine run
Served the real latest personal briefing (11-13, from the user's data directory) with a standalone read-only
PanoramaServerfrom this branch and opened/report/personal_briefing#<token>in the built-in browser: title 个人助理, usage chipsclaude-sonnet-5 · medium · 65 秒 · 192k · 4.6k(no cost chip), six section tiles (待复习 1 · 决策与检查点 4 · 饮食·本周 3 · 复习 2 · 今天 2 · 建议 3), six cards, 15 enhanced items, one "How this run went" section listing 7 files, main button 重新生成 and side button 记灵感…; clicking the side button postedopen_inspirationand the status line showed 已在肥鱼里打开 with the button re-enabled; no console errors. The first preview showed the work briefing's "generated by Claude Code in WSL" line, fixed in the second commit with a personal-specific string. Content is the user's private vault and is not attached. The pet is restarted frommainafter the merge; the island's person icon then opens the page.Tests
Red first:
tests/test_personal_report_page.pyfailed onAttributeError: personal_briefing / open_inspirationandTypeError: unexpected keyword 'open_report'before the product change; the entry test's registration sets were updated with the change. Affected families (personal, island personal, panorama, work briefing, i18n, architecture, settings personal, dynamic island): 699 passed, 1 skipped;ruff check pet testsandgit diff --checkclean. Full suite not run: no config migration, no threading change (two signal connections and one more action handler on the existing GUI-thread channel), no platform dispatch change.Docs
personal-assistant.md,config-panorama.md, roadmap M4b)🤖 Generated with Claude Code