Repository navigation
chore(deps-dev): bump ruff from 0.16.10 to 0.17.5 - #432
dependabot[bot] wants to merge 1 commit into
Conversation
Bumps [ruff](https://github.com/astral-sh/ruff) from 0.16.10 to 0.17.5. - [Release notes](https://github.com/astral-sh/ruff/releases) - [Changelog](https://github.com/astral-sh/ruff/blob/main/CHANGELOG.md) - [Commits](astral-sh/ruff@0.16.10...0.17.5) --- updated-dependencies: - dependency-name: ruff dependency-version: 0.17.5 dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
AI review: 1 P0-P2 finding(s)Dependabot bumps the dev-only linter ruff from 0.16.10 to 0.17.5 in pyproject.toml and uv.lock. The lockfile revision also goes from 3 to 5. The SDK runtime is unaffected, but the PR leaves ruff's exact 🟠 P1
Not checked: The AI review read the diff, the code, and the PR's text; it ran no tests or builds and read nothing outside this repository.
Push a fix, or have a collaborator with write access (including the PR author) add the Failing round 1 of 3 since this PR was last marked ready for review. If 3 rounds in a row find P0-P2 problems, the AI review moves the PR back to draft for the author to re-assess the approach. Human review: not needed |
| "basedpyright==1.40.1", | ||
| "pytest==9.1.1", | ||
| "ruff==0.16.10", | ||
| "ruff==0.17.5", |
There was a problem hiding this comment.
🟠 P1: ruff bumped to 0.17.5 but tool.ruff.required-version still pins ==0.16.10
pyproject.toml:144 still sets [tool.ruff] required-version = "==0.16.10". With ruff 0.17.5 installed from the lock, poe lint (ruff check --config pyproject.toml .) and poe format-check exit with a version-mismatch error before linting anything. That fails poe checks/poe quality in CI, and on main if merged. maintainers/releasing.md and the comment in .github/dependabot.yml call out this step for every ruff update. To fix it, change required-version to ==0.17.5. Also update maintainers/quality-policy.lock.json:273 and the lock digest (LOCK_SHA256 checked in scripts/check_quality_policy.py); otherwise poe policy fails next.
Found by claude-opus-5-5
| "basedpyright==1.40.1", | ||
| "pytest==9.1.1", | ||
| "ruff==0.16.10", | ||
| "ruff==0.17.5", |
There was a problem hiding this comment.
🟠 P1: Synchronize Ruff’s required-version with the dependency bump
The updated development group installs Ruff 0.17.5, but [tool.ruff].required-version still requires exactly 0.16.10. Ruff therefore refuses to run, causing scripts/check_quality_policy.sh, poe lint, and poe format-check to fail across the CI matrix. Update the required version together with maintainers/quality-policy.lock.json and its LOCK_SHA256 in scripts/check_quality_policy.py.
Found by gpt-6.1-sol
|
Looks like ruff is up-to-date now, so this is no longer needed. |
Bumps ruff from 0.16.10 to 0.17.5.
Release notes
Sourced from ruff's releases.
... (truncated)
Changelog
Sourced from ruff's changelog.
... (truncated)
Commits
c91de8aSkip the W605 source scan when a literal has no decoded backslash (#30376)0ebb77dBump version to 0.17.5 (#30380)1236ea2Defer the metaclass check in PYI034 (#30373)0b43597Parse hex escapes one ASCII byte at a time (#30374)427ae55Move thegroupedoutput format intoruff_db(#30290)f96ec54Apply per-file ignores as rule sets (#30375)489b338[ty] Renamecall-top-callabletocall-to-function-with-unknown-signature...3ffff35Speed up streaming notebook reads (#30379)75938f6Short-circuit typing member checks before resolving qualified names (#30369)5a784dfInline publicCursormethods across crates (#30368)Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)