Skip to content

Report nameless placeholders bound by name - #375

Merged
quinnj merged 1 commit into
masterfrom
claude/nameless-param-error
Oct 27, 2026
Merged

quinnj merged 1 commit into
masterfrom
claude/nameless-param-error

Conversation

@quinnj

@quinnj quinnj commented Oct 27, 2026

Copy link
Copy Markdown
Member

Binding named values (a NamedTuple or Dict) to a statement with a bare ? placeholder threw an unrelated error:

DBInterface.execute(SQLite.DB(), "SELECT ? AS a", Dict(:a => 1))
# before: ArgumentError: cannot convert NULL to string
# after:  SQLiteException("nameless parameters should be passed as a Vector")

sqlite3_bind_parameter_name returns NULL for a nameless ?, and unsafe_string threw on it before the existing "nameless parameters" check could run. The check now looks at the pointer.

Verification: new testset (fails on master with the ArgumentError, passes here); full Pkg.test() passes locally (SQLite 522/522, Julia 1.12).

🤖 Generated with Claude Code

sqlite3_bind_parameter_name returns NULL for a bare `?`, so binding a
NamedTuple or Dict to such a statement threw "cannot convert NULL to
string" from unsafe_string before the intended "nameless parameters should
be passed as a Vector" check could run.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@codecov

codecov Bot commented Oct 27, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.81%. Comparing base (6d2f5a4) to head (0a4514f).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #375   +/-   ##
=======================================
  Coverage   96.81%   96.81%           
=======================================
  Files           5        5           
  Lines         784      785    +1     
=======================================
+ Hits          759      760    +1     
  Misses         25       25           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@quinnj
quinnj merged commit d01978d into master Oct 27, 2026
9 checks passed
@quinnj
quinnj deleted the claude/nameless-param-error branch October 27, 2026 10:24
quinnj referenced this pull request Oct 27, 2026
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant