Repository navigation
Check the #66 browser-only items in real browsers - #77
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
MapChart's Google renderer now imports @vis.gl/react-google-maps and deck.gl inside try, so webpack treats them as optional, and falls back to the table when they are missing. A fixture outside the workspace builds an app without the optional peers with webpack and Turbopack in CI. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Scenarios live in web/src/e2e/*.harness.tsx (served at #/e2e/<name>, not listed) and run from e2e/browser.spec.ts in the E2E smoke workflow. These first checks cover the [P] items that did not reproduce: SortableList focus (6.6), LoadMore auto (4.4), QrCode downloads (8.7) and InlineEdit Cancel in WebKit (2.5). They pass in Chromium and WebKit and stay as regression checks. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…6.6) Disabling the fields blurs the focused one; focus now goes back to it when processing ends. Checked in Chromium and WebKit (e2e/browser.spec.ts). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
A modal dialog makes the rest of the page inert, so a menu on <body> could not be clicked. Checked in Chromium and WebKit (e2e/browser.spec.ts). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
….10) Checked in Chromium and WebKit (e2e/browser.spec.ts). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The #66 items that were left for a browser or device check, checked here with real browsers (Chromium and WebKit via Playwright) and, for 8.12, a real app build. As before, each fixed item failed a test before its fix.
numberLocaledigitsNumberInputreads and edits a locale's own digits (e.g. Arabic-Indic inar-EG);numberSymbols()also returnsdigits. Unit test.<body>).datacovers other dates; inlinedatawith the same dates keeps it.MapChartnow loads its map peers intryand shows a note and the table when they are missing.scripts/check-optional-peers.mjsbuildse2e/optional-peers(outside the workspace) with webpack and Turbopack in the Server rendering workflow.autoonLoadMore. Kept as a check.Still not checked: 3.4 (needs an Android phone with Gboard) and the 8.9
MapRadiusbullet (needs a Google Maps API key).The browser scenarios are small pages in
web/src/e2e/*.harness.tsx, served at#/e2e/<name>and left out of the navigation and the a11y and visual runs.e2e/browser.spec.tsnow runs in the E2E smoke workflow.Verification
pnpm lint,pnpm format:check, typecheck,check-docs,pnpm test(2,960 passed, 1 skipped; MCP 24), build and size (no budget changes),build:web, and thee2e/nextjsbuild and SSR check.check-optional-peers.mjs: both builds pass. Before the fix, the webpack build failed.🤖 Generated with Claude Code