Skip to content

Check the #66 browser-only items in real browsers - #77

Merged
n4ff4h merged 7 commits into
devfrom
fix/66-browser-checks
Nov 18, 2026
Merged

n4ff4h merged 7 commits into
devfrom
fix/66-browser-checks

Conversation

@n4ff4h

@n4ff4h n4ff4h commented Nov 18, 2026

Copy link
Copy Markdown
Collaborator

The #66 items that were left for a browser or device check, checked here with real browsers (Chromium and WebKit via Playwright) and, for 8.12, a real app build. As before, each fixed item failed a test before its fix.

Item Result
2.1 numberLocale digits Fixed. NumberInput reads and edits a locale's own digits (e.g. Arabic-Indic in ar-EG); numberSymbols() also returns digits. Unit test.
6.6 Form Enter-submit Fixed. Focus goes back to the field once processing ends (disabling the fields had dropped it to <body>).
6.6 Comment composer Fixed. Focus goes back to the text box after posting.
6.6 SortableList Not reproduced: focus stays on the moved item in Chromium and WebKit. Kept as a check.
6.7 Slash menu in a modal Fixed. The menu portals into the dialog, so it can be clicked and sits next to the caret.
8.10 TimeSeriesChart zoom Fixed. The zoom resets when data covers other dates; inline data with the same dates keeps it.
8.12 Optional peers Fixed. A webpack app without deck.gl failed with "Module not found" (Turbopack was fine). MapChart now loads its map peers in try and shows a note and the table when they are missing. scripts/check-optional-peers.mjs builds e2e/optional-peers (outside the workspace) with webpack and Turbopack in the Server rendering workflow.
4.4 LoadMore auto Not reproduced: no duplicate calls with an inline onLoadMore. Kept as a check.
8.7 QR object URL Not reproduced: PNG and SVG downloads complete in Chromium and WebKit. Kept as a check.
2.5 InlineEdit Cancel (Safari) Not reproduced in WebKit, which is close to Safari but not the same. Kept as a check.

Still not checked: 3.4 (needs an Android phone with Gboard) and the 8.9 MapRadius bullet (needs a Google Maps API key).

The browser scenarios are small pages in web/src/e2e/*.harness.tsx, served at #/e2e/<name> and left out of the navigation and the a11y and visual runs. e2e/browser.spec.ts now runs in the E2E smoke workflow.

Verification

  • Passed: pnpm lint, pnpm format:check, typecheck, check-docs, pnpm test (2,960 passed, 1 skipped; MCP 24), build and size (no budget changes), build:web, and the e2e/nextjs build and SSR check.
  • check-optional-peers.mjs: both builds pass. Before the fix, the webpack build failed.
  • Playwright: a11y, Thaana and browser specs in Chromium, 535 passed. The browser spec in WebKit, 8 passed.

🤖 Generated with Claude Code

agent and others added 7 commits November 18, 2026 07:44
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
MapChart's Google renderer now imports @vis.gl/react-google-maps and
deck.gl inside try, so webpack treats them as optional, and falls back to
the table when they are missing. A fixture outside the workspace builds an
app without the optional peers with webpack and Turbopack in CI.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Scenarios live in web/src/e2e/*.harness.tsx (served at #/e2e/<name>, not
listed) and run from e2e/browser.spec.ts in the E2E smoke workflow. These
first checks cover the [P] items that did not reproduce: SortableList focus
(6.6), LoadMore auto (4.4), QrCode downloads (8.7) and InlineEdit Cancel in
WebKit (2.5). They pass in Chromium and WebKit and stay as regression checks.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…6.6)

Disabling the fields blurs the focused one; focus now goes back to it when
processing ends. Checked in Chromium and WebKit (e2e/browser.spec.ts).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
A modal dialog makes the rest of the page inert, so a menu on <body> could
not be clicked. Checked in Chromium and WebKit (e2e/browser.spec.ts).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
….10)

Checked in Chromium and WebKit (e2e/browser.spec.ts).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@n4ff4h
n4ff4h merged commit a8ab629 into dev Nov 18, 2026
4 checks passed
@n4ff4h n4ff4h mentioned this pull request Nov 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant