Repository navigation
Focus management (#66, Part 6) - #73
Merged
Merged
Conversation
…rmation (#66, 6.1) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…ed (#66, 6.3) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
… 6.4) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Like the other hooks; the build will only add the banner to modules that declare it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
76 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the [C] items in Part 6 (focus management) of #66. Each item has a jsdom test that failed first, asserting
toHaveFocus()after user-event interactions.RecordActionsMenu:triggerRefis now attached to the "More actions" button, so a confirmation opened from the menu returns focus to it. The test failed with focus on<body>.tabindex=0.BulkActionBar: opening an action's form focuses its control (the element with the form id, or else the first form control). Cancel puts focus back on the action button. The test failed with focus on<body>.AdditionalFilesUpload: after a new file is removed, the picker gets focus only once it has re-rendered, which matters atmaxFiles, where it was still disabled. FileInput's deferred focus is now a shared internal hook,hooks/use-focus-after-render.ts, used by both components. The test failed with focus on<body>.ExportMenu: the button isaria-disabledwhile exporting instead ofdisabled, so focus returns to it as the menu closes. The menu can't be opened again until the export finishes. The test failed with focus on<body>.Skipped ([P] / device check)
Could not reproduce
Behaviour/API changes worth noting
ExportMenu: while exporting, the button isaria-disabled+aria-busy(styledaria-disabled:opacity-50) instead ofdisabled. Thedisabledprop still sets nativedisabled.EditorToolbarProps(internal) no longer acceptsref, because the toolbar uses its own ref on the root.Verification
pnpm lint,pnpm format:check,pnpm typecheck: passpnpm --filter @javaabu/onu exec vitest run --maxWorkers=3: 197 files, 2863 passed, 1 skippednode scripts/check-docs.mjs: Docs OKpnpm build && pnpm --filter @javaabu/onu size: pass, no budget changes🤖 Generated with Claude Code