Repository navigation
keep queued startup enable and disable commands - #46
Merged
Merged
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Startup enable and disable clicks are no longer latest-wins. While the startup worker is busy, every accepted toggle is queued with its entry id and run in that order.
Test plan
cargo fmt --all -- --checkcargo check,cargo clippy, andcargo test— not run to completion here. The default target isx86_64-pc-windows-msvc, and resource compilation stops becausellvm-rcis not installed. It was not installed for this change. Linking the Windows test binary also needslink.exe, which this Linux environment does not have.