Repository navigation
reel: a funk2 shot can take its text mask from a copy line - #30
Open
IsraelWebDev wants to merge 2 commits into
Open
IsraelWebDev wants to merge 2 commits into
IsraelWebDev wants to merge 2 commits into
Conversation
A funk2 source may name a copy line with mask_copy_id. The recipe's one text-masked layer then draws that copy text, so the copy lock and the text audit cover a masked word the same as a caption. - schema: Source.mask_copy_id (funk2 only) - copydeck: the id is a copy reference (existing unknown-id check and copy lock) - validate: exactly one text-masked layer, and that mask carries no text of its own - render: copy text becomes the mask text; text_mask refuses inexact drawing - audit: one <shot>/source_mask/0 entry per shot; a missing entry fails ok - docs/reel.md section; docs/specs/reel-mask-copy.md - tests/reel/test_mask_copy.py Co-Authored-By: Claude Haiku 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_019RsXeZ8D98yMUSMFhvgEiD
The audit now reads Source.mask_copy_id, so the test stub needs the field. Co-Authored-By: Claude Haiku 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_019RsXeZ8D98yMUSMFhvgEiD
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A funk2 source may name a copy line with mask_copy_id. The recipe's one text-masked layer then draws that copy text, so the copy lock and the text audit cover a masked word the same as a caption.
source: {"funk2": "recipe.json", "mask_copy_id": "hook"}. The recipe's text-masked layer then draws the copy text. That makes a kinetic-type word covered by the copy lock and the reel's text audit, as captions already are. Source: promo feedback of 2026-11-12,claude/promo-feedback-2026-11-12.md. Spec:docs/specs/reel-mask-copy.md.Source.mask_copy_id, funk2 only.<shot>/source_mask/0intext_audit.json, with the exact text and its frames. A missing entry failsok.docs/reel.md.Tests
tests/reel/test_mask_copy.py(7 tests): parse (funk2 only), copy reference, validate (recipe without text validates; unknown copy id; own text refused; two text masks refused). All 7 pass locally on Windows.tests/test_catalog.pyandtests/test_mask_bevel_text.py: 22 passed locally.ruff checkandruff format --checkpass onfunkboxandtests.Not in this change
Claude-Session: https://claude.ai/code/session_019RsXeZ8D98yMUSMFhvgEiD