Repository navigation
Enable AdaptiveCpp builds - #2384
Open
ndgrigorian wants to merge 16 commits into
Open
ndgrigorian wants to merge 16 commits into
ndgrigorian wants to merge 16 commits into
Conversation
ndgrigorian
commented
Sep 18, 2026
ndgrigorian
commented
Collaborator
- Have you provided a meaningful PR description?
- Have you added a test, reproducer or referred to an issue with a reproducer?
- Have you tested your changes locally for CPU and GPU devices?
- Have you made sure that new changes do not introduce compiler warnings?
- Have you checked performance impact of proposed changes?
- Have you added documentation for your changes, if necessary?
- Have you added your changes to the changelog?
- If this PR is a work in progress, are you opening the PR as a draft?
|
View rendered docs @ https://intelpython.github.io/dpctl/pulls/2384/index.html |
Collaborator
|
coverage: 74.996% (+0.03%) from 74.963% — feature/build-with-adaptivecpp into master |
ndgrigorian
force-pushed
the
feature/build-with-adaptivecpp
branch
3 times, most recently
from
September 19, 2026 06:13
cee555b to
d1888a5
Compare
ndgrigorian
changed the base branch from
master
to
feature/drop-host-task-object-management
September 20, 2026 21:06
ndgrigorian
force-pushed
the
feature/drop-host-task-object-management
branch
2 times, most recently
from
November 4, 2026 19:10
920ff28 to
3e31cd7
Compare
Base automatically changed from
feature/drop-host-task-object-management
to
master
November 5, 2026 17:28
Also add OpenMP backend
ndgrigorian
force-pushed
the
feature/build-with-adaptivecpp
branch
from
November 5, 2026 17:41
d1888a5 to
4dd89c6
Compare
Also fix some tests when building with level zero enabled by AdaptiveCpp
ndgrigorian
force-pushed
the
feature/build-with-adaptivecpp
branch
from
November 5, 2026 17:55
4dd89c6 to
307f51c
Compare
Queues created without a handler inherited the AdaptiveCpp default context handler, which calls std::terminate from ~queue(), e.g. after a failed USM allocation on the OpenCL backend.
Set DPCTL_VERBOSITY=error and use --capture=sys so SYCL errors reach the log.
ndgrigorian
marked this pull request as ready for review
November 5, 2026 18:12
ndgrigorian
requested review from
antonwolfy and
vlad-perevezentsev
as code owners
November 5, 2026 18:12
The adaptivecpp HIP plugin links libamdhip64.so.6; a fresh solve now pulls ROCm 7, the plugin fails to load, and its warning on stderr fails the py_sycl_ls example.
Every filter-string test probing an absent device logged an [ERR] line before skipping, thousands per run. The abort it was added to diagnose is fixed; --capture=sys still lets native output reach the log.
The barrier kernel now depends on the queue's wait list, as ext_oneapi_barrier does. Also drop the unused AdaptiveCpp SET_LOCAL_ACCESSOR_ARG.
component_devices returns an empty tuple, can_compile is false for spirv and opencl, and enable/disable_peer_access raise ValueError.
Restore DPCTL_WITH_REDIST and DPCTL_OFFLOAD_COMPRESS options, validate DPCTL_SYCL_PROVIDER, default it in a standalone libsyclinterface build, and derive ACPP_TARGETS (keeping generic) only when the user has not set it, without caching it.
Use a skipif marker in _device_attributes_checks, which is imported before the marker is registered.
| m2 = MemoryUSMDevice(nbytes, queue=q) | ||
| except USMAllocationError: | ||
| pytest.skip("Not enough memory") | ||
| ev = q.memcpy_async(m1, m2, nbytes) |
Collaborator
There was a problem hiding this comment.
Following up on #2384 (comment): under AdaptiveCpp on the OpenCL CPU this test passes without the fix. The first barrier JIT-compiles its kernel (about 200 ms), so the copy is done before it. One barrier first makes the test fail without the fix (8/8 on omp and ocl) and pass with it:
q.submit_barrier().wait() # compile the barrier kernel first
ev = q.memcpy_async(m1, m2, nbytes)This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.