Repository navigation
fix: recast autocast Linear and Matmul outputs to fp32 - #264
Open
Nebulixeay wants to merge 2 commits into
Open
Nebulixeay wants to merge 2 commits into
Nebulixeay wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
With autocast enabled, Linear and Matmul can return lower-precision tensors. The recorded MLU BF16 GPT-2 path encountered downstream gradient dtype mismatches. This change represents the lower-precision operator outputs as FP32 for the downstream path.
Change
After
SetupContextand before saved-variable wiring, convert outputs of the configured lower-precision autocast operators to FP32 when their dtype matches the active autocast dtype. Transfer non-differentiable output markings to the replacement tensor. Disabled autocast, unrelated operators, null outputs, and outputs with other dtypes keep their existing tensors.The conversion preserves the rounded lower-precision values; it does not recover FP32 precision. Only
infini_train/src/autograd/function.ccchanges, including its direct includes and formatting. The framework API and operator list are unchanged.Validation
git diff --checkpass.