Repository navigation
Fix malformed DOI and reference output in exported CITATION.cff - #93
Merged
Merged
Conversation
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
egrace479
marked this pull request as ready for review
November 16, 2026 17:25
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Citation CFF references aren't used in any capacity (not read, nor human-readable), so switch to Zenodo JSON only Issue was linked in citation formatting Used Claude Opus 5.5 to help in resolution, test cleaning, and documenting fixes
beanbean9339
approved these changes
Nov 19, 2026
beanbean9339
left a comment
Collaborator
There was a problem hiding this comment.
looks good. didnt find any blocking issues and updated test cover expected behavior
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Importing a repo's
CITATION.cffproduced a malformed top-level DOI (quotes and the trailing YAML comment were kept, then escaped on export), and free-text DOI references were exported with the DOI duplicated in the title and aurlpointing at the Zenodo DOI.Changes
Importer scalar parsing (
githubImporterUtils.js)stripWrappingQuotesnow removes a trailing YAML comment after a quoted value, and trailing comments on unquoted values.doi: "10.5281/zenodo.22310628" # Persist ...became"\"10.5281/...\" # Persist ...".10.5281/zenodo.22310628.Importer reference block (
githubImporter.js)replace(/^"|"$/g, ''), sodoi: "..." # noteparses the same way as top-level scalars.Export of free-text DOI references (
citation.js)