Repository navigation
Speed up filtering - #126
Merged
Merged
Conversation
alexhroom
force-pushed
the
119-faster-filters
branch
from
May 15, 2026 11:21
6fe31a7 to
cd02853
Compare
alexhroom
force-pushed
the
119-faster-filters
branch
from
May 19, 2026 10:14
072e80b to
815f339
Compare
alexhroom
marked this pull request as ready for review
May 19, 2026 10:29
alexhroom
force-pushed
the
119-faster-filters
branch
from
May 19, 2026 10:44
b53c409 to
815f339
Compare
Collaborator
|
I have found a bug, but Im not sure where its coming from. If I use the GUI to load some data and press Just checked main seems to be fine |
AnthonyLim23
approved these changes
May 21, 2026
AnthonyLim23
left a comment
Collaborator
There was a problem hiding this comment.
I cant reproduce the bug, so I assume its a mistake on my part. This is a significant improvement to the performance of the code.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes #119 by changing the filtering. Instead of reducing the size of the arrays to the filtered values, the whole arrays are now passed to the histogram code and the filtered-out values are given a weight of zero instead.