Repository navigation
Avoid vendoring pysrim - #103
Merged
Merged
Conversation
include EVA in requirements.txt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolve issue #27 The version of pysrim on PyPi is outdated and used deprecated yaml syntax, which causes the module import to fail. This issue was previously solved by vendoring pysrim into EVA source code, but this was never a permanent solution.
The yaml error has been resolved in the pysrim source code, but was never uploaded to PyPi. The error can therefore be resolved by adding the git repository as a dependency rather than the PyPi version.