Repository navigation
Preserve 64-bit Revit element IDs in reads and exports - #274
Merged
Merged
Conversation
mahach666
marked this pull request as ready for review
November 19, 2026 14:58
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change
Preserve exact signed 64-bit Revit element IDs from schema-declared tables and partition records through reading, lookup and export. Existing 32-bit APIs use document-local keys when remapping is necessary. The new signed 64-bit lookups and accessors expose exact source IDs for elements and references.
Full JSON carries the source-ID map and writes remapped references as decimal strings. Compact JSON keeps its existing string object IDs. Scene maintains local numeric geometry links and includes exact source IDs as text. IFC product tags carry source IDs.
Refs #269. Revit parity for UniqueId and IFC GUID remains open. Wide creation IDs are retained. The verified UInt32 derivation only applies within its supported range.
Synthetic verification
Byte-for-byte comparison
Exported two Revit 2027 fixtures with the same options and a fixed IFC timestamp using base
47e7776and PR head36ac652. All eight outputs compared byte for byte after merging main. The seven synthetic cases also passed again on .NET 8 and .NET 10.Local checks
dotnet test RvtIO.slnx -c Releasepassed. .NET 8 had 10,941 passed and 447 skipped. .NET 10 had 10,945 passed and 447 skipped.RvtIO.Scenepassed on both frameworks.git diff --checkpassed.