Skip to content

Read Revit element ID flags and shared fragment poses - #268

Merged
mahach666 merged 1 commit into
mainfrom
codex/nwc-revit-cache-261
Nov 19, 2026
Merged

mahach666 merged 1 commit into
mainfrom
codex/nwc-revit-cache-261

Conversation

@mahach666

@mahach666 mahach666 commented Nov 19, 2026 •

Copy link
Copy Markdown
Collaborator

Fixes #261.

  • Accept the observed class-66 element ID flags 0x01000000 and 0x00020000. Keep the existing validation of the key and value layout.
  • Permit pose slots to reference a completed class-14, class-15 or class-16 pose. Keep pointer class and identity checks and derive the fragment count bound from the shortest permitted record.
  • Add tests that open a container with the alternate flag and check its element ID, and that preserve mesh ownership and world placement in a compact stream of shared poses. Keep the tests that reject unsupported flags and reference classes.

Confirmed that the new tests reproduce both refusals on the old parser, including the count failure on compact input. Full solution tests passed on .NET 8 and .NET 10, along with formatting and the CLI build. The original Snowdon_test.nwc was not attached to the issue.

The fixed CLI opens both minimal reproductions on .NET 8 and .NET 10. A local comparison of 53 existing NWC files against the published 0.15.0 reader produced identical JSON digests for every file.

@mahach666
mahach666 merged commit 6931c17 into main Nov 19, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Revit NWC fails to open: class-66 flags 0x00020000 rejected, and shared poses rejected in LcOpNwdFragments

1 participant