Repository navigation
Restore GLB packing throughput with bounded batches - #265
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Follow-up to #264 and #46.
Measurements
Windows, .NET 10.0.12 Release. The same synthetic model uses 12 meshes with 60,000 vertices each. Medians of 15 timed exports after four warm-up rounds, rotating the three exporters and writing to
Stream.Null.All three exporters produced identical 18,727,900-byte GLBs. SHA-256 was
7ed1b5462175c6e810acf9b7933826d7bcb1f1d0f22542840f0bc10883a29637. The reproduction is documented indocs/test-fixtures.md.A second run on the committed code measured 18.08 ms, versus 20.98 ms after #264 and 19.77 ms before it. All three GLBs were again byte-identical.
Verification