Skip to content

Fill section faces and rotate the section box - #71

Merged
mahach666 merged 2 commits into
mainfrom
codex/section-fill-rotation
Nov 18, 2026
Merged

mahach666 merged 2 commits into
mainfrom
codex/section-fill-rotation

Conversation

@mahach666

@mahach666 mahach666 commented Nov 18, 2026 •

Copy link
Copy Markdown
Contributor

Changes

  • Add an opt-in stencil fill for planar cross-sections and the six faces of either box mode. Classify closed, consistently wound meshes on first use and reuse the visible mesh ranges for the stencil.
  • Rotate the section box about Z using the ring or keyboard-accessible angle slider. Move and resize along the rotated box axes while holding the opposite face still.
  • Keep the exported section format and saved-view behavior. Fill is visual and picking and measurement still use model triangles.

Verification

  • Release build, 176 .NET tests per target framework with the real RVT CLI test, 165 JS unit tests and 214 end-to-end tests in Chromium and Firefox on Windows and Linux. The cap regression samples the inside and outside of the rotated box in the same composited frame. The two cap scenarios also passed 20 targeted Firefox runs on Linux.
  • DocFX with warnings treated as errors and a rebuild of the embedded viewer bundle.
  • Saved fresh standalone pages from Schependomlaan IFC (3,337 elements) and racbasicsampleproject RVT (467 elements). Verified caps on planes and both rotated box modes, toggling fill, pointer and keyboard rotation, perspective and orthographic cameras, and the panel at 390 px in Chromium and Firefox.
  • Synthetic-400k on the integrated Radeon with fill off, four pairs in alternating order. Previous main p95 was 50.0, 33.5, 33.5 and 50.0 ms. This commit was 33.5, 33.5, 33.4 and 33.4 ms. Median of the submitted triangle medians was 12.33M and 12.37M respectively.
  • In one paired orbit run on Schependomlaan with the same horizontal clip, measured p95 was 16.8 ms with fill off and 16.8 ms with fill on. Both submitted 247,472 median triangles in the visible model pass.

Closes #20

@mahach666
mahach666 merged commit e3208b9 into main Nov 18, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Section fill (caps) and a rotatable section box

1 participant