Skip to content

Narrow GPU picks inside instanced cells - #68

Merged
mahach666 merged 3 commits into
mainfrom
codex/instanced-pick-bounds
Nov 18, 2026
Merged

mahach666 merged 3 commits into
mainfrom
codex/instanced-pick-bounds

Conversation

@mahach666

Copy link
Copy Markdown
Contributor

Changes

  • Trim the suffix beyond the last visible instance whose conservative bounds intersect the GPU pick tile. Preserve slot order, IDs and the GPU depth test.
  • Keep the pick pass independent of the orbit detail cut and restore the visible render state afterward.
  • Add an A/B benchmark and document the results. Rebuild the embedded offline viewer.

On integrated Radeon, p95 for the same hit pixels fell from 10.4 to 3.0 ms at 400,000 elements and from 25.7 to 7.5 ms at 1 million. The hit IDs and positions matched in both modes. The merged Schependomlaan control submitted the same geometry in both modes.

Verification

  • Release build, reproducible viewer bundle, and DocFX with warnings as errors.
  • 159 JavaScript unit tests and 199 Playwright tests each on Windows and Linux.
  • 176 tests each on .NET 8 and .NET 10.
  • Exported Schependomlaan IFC and racbasicsampleproject RVT. Compared picking and measurement targets with both projections, float and RGBA8 picking, clipping, and hidden objects.

Refs #12

@mahach666
mahach666 merged commit 4288013 into main Nov 18, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant