Repository navigation
Conversation
2 tasks
2 tasks
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add a repeatable #1585 HTTP-client lifetime measurement through the real managed Axum runner, with GitHub Actions summaries and downloadable evidence. The existing EdgeZero cutover already shares its underlying transport, and the selected Next.js regression did not reproduce. Preserve current production behavior; do not add another pool.
Ownership: these application-level measurements belong in Trusted Server. Transport construction, pooling, budgets, cancellation and streaming remain EdgeZero functionality. No SDK correction was demonstrated or implemented. This does not complete EdgeZero #394's broader streaming acceptance or the settings/registry/store lifetime work in #1623.
Stacked on #1506 (
spec/edgezero-pr275-migration). The original local measurement used its pinned head: Trusted Serverfeaf3df5d1c9bb2dca64158480725cb555ab9c26, EdgeZero9d02d7b3185b49e81d9ac972ca3feef932ed848a. Main's old per-request client was not the measured implementation. The workflow now builds its checked-out branch directly, so the prerequisite and consumer stay together. Dependency order is unchanged; the stack was joined with a history-preserving merge, without rebasing or force-pushing.Findings and numbers
[]; 15 chunked incoming POSTs were correctly reframed with Content-Length 2 upstream.Final-run milliseconds, median / p95:
These are sequential local direct-versus-managed path measurements, not a causal pooled-versus-fresh comparison. Chunked uploads include intentional pacing; browser cycles include loading and return navigation. A fresh outbound transport comparison was unnecessary because the current transport already reuses connections and the selected correctness checks pass.
Counterevidence retained: the first proxied real action was rejected by Next.js's origin check despite the complete multipart body arriving. Allowing only the fixture's exact public proxy origin in
serverActions.allowedOriginsmade the workflow pass while preserving browser Origin. No production Host/Origin policy changed. An unconfigured split-origin deployment can still reject actions.The historical fixture used an unknown action ID, not a valid action/redirect. Its original root cause remains uncertain. Successful real-action checks are additional coverage, not an exact reconstruction of that old stack.
Repeatable GitHub Actions measurement
The
Axum Next.js transport measurementworkflow runs on relevant PR changes and supports manual dispatch when available on the default branch. It builds this branch's actual managed Axum runner with the pinned Node/Rust and locked Next/browser dependencies on Ubuntu 24.04, which the locked Playwright version supports. The initial Ubuntu 26.04 runner failed browser installation before runtime measurements; the job now pins the compatible image. The superseded attempt stalled in unrelated OS package downloads. The fixture now downloads the locked browser and retains Playwright's normal validation of the runner's preinstalled libraries, without upgrading runner packages. Correctness and reuse assertions can fail the job; timings have no pass threshold and global connection counts are observations, not a fixed target.Each successful run writes fresh counts and median/p95 timings to the job summary and uploads raw synthetic TCP requests, parsed receipts, per-request/browser observations, source/tool/binary identity and logs. Failed runs retain available diagnostics. The historical table above remains identified as local evidence; CI numbers are separate.
Local reproduction:
The source preflight checks the actual managed runner/client integration, rather than requiring a historical commit to survive a squash merge. Services and browser descendants use owned process groups with bounded cleanup; the recorder flushes before analysis. The SIGTERM control stopped even a descendant deliberately ignoring SIGTERM and released all three ports.
Recorder latency control
The first successful hosted TypeScript run passed correctness and reuse checks but showed a roughly 40 ms mode in managed API timings. The plain TCP recorder still had Nagle buffering enabled. The fixture now sets
TCP_NODELAYon both recorder sockets and records that setting in metadata; production transports are unchanged. The Linux control run passed: managed GET median fell from 42.760 ms to 2.405 ms while direct GET remained near 1.4 ms; POST median fell from 51.316 ms to 11.185 ms. Production source, locked SDK/tool versions and build flags match; the binaries were rebuilt and their hashes differ. This supports recorder buffering as the confounder. The runs used separate hosted VMs, so this is not a randomized causal pooling benchmark. The historical local table remains separately labeled.Hosted measurement on the final code revision
Actions run 44516951107 passed at head
fc238935290effd2db2abee6f5e417e5902798b7; the tested PR merge revision was3922847b2173ab98abaee6a48b23c5f448079758. Its job summary contains the table and its artifact contains raw synthetic receipts, individual observations, metadata and logs.204 upstream requests, 18 used connections; all 30 historical POSTs used one connection. All 18 action cycles per target passed (15 hydrated + 3 JavaScript-disabled), including concurrent contexts and exact cookies/bodies.
These are fresh Linux observations with recorder TCP_NODELAY enabled, separate from the original local table above. They characterize complete paths, not pooling's causal benefit.
Changes
docs/internal/measurements/2026-11-19-1585-axum-nextjs.mddocs/internal/measurements/2026-11-19-1585-axum-nextjs-results.json.github/workflows/axum-nextjs-measurement.ymlscripts/measure-axum-nextjs/scripts/README.mdRelated issue
Related #1585. No automatic closing keyword: the report answers the HTTP measurement question without claiming the broader SH-1 settings, registry and store criteria are complete.
Spec
Not a product feature. Measurement fixtures, automation and documentation; no production runtime, dependency or SDK behavior changes. Existing lockfiles supply fixture dependencies.
Test plan
On the measured prerequisite revision:
cargo test-axum: 20 library + 40 route tests passed; two documentation examples ignored.cargo clippy-axum.For the report and automation:
npm run checkwith Node 24.20.0).No full cross-adapter CI rerun is claimed for this report. Hosted checks are separate from the captured runtime evidence. The fixture is now repeatable locally and in CI; raw traces are uploaded per run rather than committed. Scope is local HTTP/1, the pinned Next.js version and explicit allowed proxy origin; TLS/HTTP2, other versions, idle/sustained-load behavior and complete cancellation/drain qualification remain unmeasured.
Checklist