Repository navigation
Conversation
3 tasks
prk-Jr
changed the base branch from
feat/s2s-eid-vendors
to
feat/axum-identity-providers
November 18, 2026 15:19
prk-Jr
force-pushed
the
fix/1555-provider-eid-opt-outs
branch
from
November 18, 2026 15:19
7ac8b5e to
ee7a110
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #1566 (
feat/axum-identity-providers), with the focused diff based on3d62f4dd7efb1192a15be7da0011511b1ee316a7. The dependency order is #1488 → #1566 → this PR. #1566 currently conflicts with #1488. Keep this PR in draft until the dependency stack is refreshed and the resulting revisions are revalidated. Default Axum EC activation also remains blocked by its missing geolocation service; controlled application services verify the identity route behavior below.Summary
ts-eidscookie and/auctionbody IDs from bidders while an enabled source owner has a remembered opt-out, across Fastly and Axum initial-page, direct and page-bids auctions.Changes
crates/trusted-server-adapter-axum/src/app.rscrates/trusted-server-adapter-axum/src/identity.rscrates/trusted-server-adapter-axum/src/identity_tests.rscrates/trusted-server-adapter-fastly/src/app.rscrates/trusted-server-core/src/auction/endpoints.rscrates/trusted-server-core/src/ec/admin.rscrates/trusted-server-core/src/ec/eids.rscrates/trusted-server-core/src/ec/identify.rscrates/trusted-server-core/src/ec/mod.rscrates/trusted-server-core/src/ec/pull_sync.rscrates/trusted-server-core/src/ec/registry.rscrates/trusted-server-core/src/publisher.rsdocs/guide/api-reference.mddocs/guide/axum-dev.mddocs/guide/configuration.mddocs/superpowers/plans/2026-11-18-provider-eid-opt-outs.mddocs/superpowers/specs/2026-11-18-provider-eid-opt-outs-design.mdCloses
Closes #1555
Spec
Bug fix; no configuration or persisted-schema changes.
Spec: Provider opt-out enforcement for client EIDs
Plan: Provider opt-out enforcement implementation plan
An opt-out applies only while its end time is greater than the request time and only for an enabled owner of that source. Client EIDs cannot clear it. Missing, failed or mismatched row snapshots retain existing degraded behavior. Legacy expiry occurs on reads, with no migration or invented timestamp; rollback can resume serving those legacy records. No-provider output and existing vendor/global consent gates remain covered.
Test plan
All local gates below passed for the source tree committed as
ee7a11031. JavaScript tests used two workers with unchanged time limits. Final runtime artifacts omit debug symbols; tool versions remain pinned.cargo test-fastly && cargo test-fastly-reuse && cargo test-axum && cargo test-cloudflare && cargo test-spincargo fmt --all -- --checkts config push --adapter fastly --local: 88 cases on stock Viceroy and 90 on an explicitly synthetic TLS-fingerprint emulator. The latter includes two same-visitor provider-cookie opt-back-in controls. Controlled local backend mappings deliver requests to an owned bidder fixture. Cases cover initial-page/page-bids/direct auctions, cookie/body inputs, active/expired opt-outs, legacy/live/expired provider records, no-provider controls, repeated visitors and policy-only read/write preservation.ts config push --adapter axum --local, the documented envelope environment bridge, the actual settings loader and full application router. Explicit fixtures supply countryDEand redirect ID5/PBS transport to owned local peers. An ID5 opt-out response creates stored memory; repeated same-visitor requests suppress forged IDs without retrying the provider, while unrelated IDs survive. Opt-back-in restores delivery, and a short-lived ConnectID demonstrates live-to-expired behavior.These are local controlled-runtime results. They do not establish live-vendor, deployed-edge or real-browser behavior. The draft remains subject to dependency refresh and the default Axum geolocation qualification above. Hosted CI is checked separately on the published revision.
Checklist
unwrap()added in production code.logmacros.