Skip to content

Pin Wrangler for the Cloudflare smoke and CI - #1625

Open
prk-Jr wants to merge 3 commits into
spec/edgezero-pr275-migrationfrom
fix/1610-wrangler-pin
Open

prk-Jr wants to merge 3 commits into
spec/edgezero-pr275-migrationfrom
fix/1610-wrangler-pin

Conversation

@prk-Jr

@prk-Jr prk-Jr commented Nov 18, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • Restore the local Cloudflare smoke by pinning Wrangler 4.83.0 in the shared tool manifest.
  • Make all three Cloudflare CI installations read that pin, including browser jobs that change directories.
  • Record the passing Cloudflare smoke in the cutover specification and remove the completed pin follow-up while preserving historical results.

Stacked on #1506 (spec/edgezero-pr275-migration) because its cutover specification is absent from main. Retarget after #1506 merges.

Changes

File Change
.tool-versions Declare Wrangler 4.83.0 as the common runtime version.
.github/workflows/integration-tests.yml Read and require the manifest pin in both Wrangler installations using the absolute workspace path.
.github/workflows/worker-auction-deadlines.yml Read and require the same pin for Cloudflare deadline fixtures.
docs/superpowers/specs/2026-10-17-edgezero-pr275-hard-cutover-design.md Replace the current missing-pin failure with verified smoke results and remove the completed follow-up.
docs/superpowers/specs/2026-11-18-1610-wrangler-pin-design.md Record scope, acceptance criteria, and two design review rounds.
docs/superpowers/plans/2026-11-18-1610-wrangler-pin.md Record implementation, validation, and delivery steps.

Closes

Closes #1610

Spec

Not a feature; tooling and CI correction. Design and implementation plan.

Test plan

  • Reproduce the missing-pin failure on the base.
  • Run the Cloudflare smoke twice, including the final committed head, with a fresh CLI and Worker: all four missing-binding controls return HTTP 500 with expected diagnostics; the configured publisher request returns HTTP 200, the origin sentinel, and a rewritten asset URL.
  • Verify all three workflow blocks select 4.83.0 and fail when the pin is absent; check shell and YAML syntax.
  • Rust tests: Fastly, reusable Fastly sandbox, Axum, Cloudflare, Spin, parity, native build-digest, and CLI.
  • All eight target-matched Clippy aliases and native build-digest Clippy.
  • cargo fmt --all -- --check.
  • JS tests: 80 files and 3,299 tests pass with default workers and with one worker; JS build and format pass.
  • Docs and Markdown format, including the final three changed documentation files.
  • Fastly, Axum, and Cloudflare builds; Fastly release build.
  • Actual Fastly deadline fixtures and Cloudflare/Spin deadline fixture builds, Clippy, and runtime checks.
  • Domain and WASM-clock lints; documentation-proposal, CI Node pin, release-producer, and Fastly response script checks.
  • Independent reviews resolved all findings; local and GitHub signature verification pass for the published head.

All 40 reconciled Rust, runtime, lint, and script gates exit 0. The JS, formatting, workflow probes, and Cloudflare smoke checks above also pass. Runtime validation is local; no deployed Cloudflare access is needed.

Checklist

  • Feature spec requirement does not apply; design and two review rounds are linked above.
  • Changes follow AGENTS.md conventions.
  • No production Rust code is changed.
  • No application logging is changed.
  • Existing smoke and workflow checks verify changed behavior.
  • No secrets or credentials committed.

@prk-Jr prk-Jr self-assigned this Nov 18, 2026
@prk-Jr
prk-Jr marked this pull request as ready for review November 18, 2026 12:13
@prk-Jr prk-Jr linked an issue Nov 18, 2026 that may be closed by this pull request
3 tasks
Takes #1506's new head feaf3df, which brings #1506's repin of
EdgeZero to rc/identity at 9d02d7b3. The merge is clean, and this PR's tree
changes only by that repin.
@aram356 aram356 mentioned this pull request Nov 19, 2026
20 of 21 tasks
@prk-Jr
prk-Jr added this pull request to stack #1633 November 19, 2026 06:59

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Pin Wrangler in .tool-versions so smoke-cloudflare.sh runs

2 participants